-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getResourceOwner parameter type #956
Comments
While you are absolutely correct: it would be better to expect Interfaces and not specific implementations, it is to consider that this small change would require a new major release because it would break bacward compatibility, as it happened in the past (ref #753 and #752 for example). And I highly doubt a new major release will be created only for this alone. Edit: as a matter of fact this is already being tracked in #897 :) |
Hello,
Doesn't would be better to set the type of the $token parameter here to AccessTokenInterface instead of AccessToken?
oauth2-client/src/Provider/AbstractProvider.php
Line 765 in 8c7498c
what do you think?
Thanks
The text was updated successfully, but these errors were encountered: