Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publication workflow became incompatible with our versioning scheme #183

Open
Fabilin opened this issue Dec 18, 2024 · 0 comments · May be fixed by #184
Open

Publication workflow became incompatible with our versioning scheme #183

Fabilin opened this issue Dec 18, 2024 · 0 comments · May be fixed by #184
Assignees
Labels
bug Something isn't working

Comments

@Fabilin
Copy link
Member

Fabilin commented Dec 18, 2024

Recent versions of the np package disallow setting a specific release version, which breaks traditional use of the manual workflow (related issue: sindresorhus/np#748).

Since our versioning scheme is not truly semantic-based (major representing the year, and minor being either March or September), we cannot use the built-in update keywords either.

Solutions

The solution could be one of the following:

  • Change our versioning scheme (major change, out of line with the rest of the TOCK ecosystem)
  • Downgrade the np package to the last known working version (8.0.4)
  • Remove the np dependency and rely on regular yarn publish

Considering the np package is not intended to be used in CI in the first place, I believe the right move is to cut it from the workflow. It should also be noted that the prerelease preset bumped only the patch version component, which was usually inadequate considering we most often make prereleases for major versions.

@Fabilin Fabilin added the bug Something isn't working label Dec 18, 2024
@Fabilin Fabilin self-assigned this Dec 18, 2024
Fabilin added a commit to Fabilin/tock-react-kit that referenced this issue Dec 19, 2024
@Fabilin Fabilin linked a pull request Dec 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant