Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing (?) caret-color settings for generated themes #73

Open
aphirst opened this issue Sep 21, 2020 · 4 comments
Open

Missing (?) caret-color settings for generated themes #73

aphirst opened this issue Sep 21, 2020 · 4 comments

Comments

@aphirst
Copy link

aphirst commented Sep 21, 2020

I've been very satisfied with oomox on my new setup, using my preferred and familiar numix brave theme.

I am however also a user of ibus for Japanese input, and it seems that the defaults for the oomox themes do not set all the necessary values. ibus/ibus#1871 (comment)

The accessibility overlay defaults to a black background, and with black text it obviously means you can't read the kanji selections.

If I manually set gtk-secondary-caret-color like in the linked thread to be the same color as, say, Selected Background (729fcf for shiki brave, for example), I get the desired behaviour (legible text).

Has this value been deliberately omitted in the generator?

@actionless
Copy link
Member

do you mean those?
2020-09-22--1600729246_645x175_scrot

@actionless actionless transferred this issue from themix-project/themix-gui Sep 26, 2020
@actionless actionless changed the title Missing (?) caret-color settings for Oomox/numix generated themes Missing (?) caret-color settings for generated themes Sep 26, 2020
@aphirst
Copy link
Author

aphirst commented Sep 27, 2020

I may mean those, yes! I am currently trying to work out, either from the code or from people in the ibus community, which properties are used for these dialogs, as there's another one (the emoji selector) that isn't helped by setting just the one parameter I mentioned in my OP. Sorry about the delay, but when problems lie at the intersection between unrelated projects, I figured it was best to gather that info before jumping any guns.

@actionless
Copy link
Member

TBH i never used that feature of oomox theme myself, it was added by @cwendling here: themix-project/themix-gui#69 mb he could help to debug this

@cwendling
Copy link

I'm not quite sure, but maybe that's a specific use case of IBus. I see that in my MR @actionless linked, I set the property on something more specific than *, so that might be the problem. I don't remember if there was a reason to do that apart that GTK only used it there (in views and entries), but I see 2 solutions: set it more globally, or make sure the IBus panel has the proper view class or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants