-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button id prop not passed to tag when disabled #1336
Comments
Is adding |
That would fix my specific issue, but I think users will expect all the props to be passed into the svelte:element tag when the button is disabled, since that's the behavior when it's not disabled. Why did |
By adding |
Gotcha - what if we do something like this? #1339 Just opened the PR to show the change, I haven't tested it since I don't have the local dev environment for this setup. Feel free to take over / edit that PR or close it and open your own |
Describe the bug
The fix to this issue (commit here) introduced a bug - the
id
prop is no longer passed to thebutton
tag when theButton
isdisabled
because$$restProps
is no longer being passed tosvelte:element
when the Button is disabled. For us, this means that we can't target a button by id with a tooltip when that button is disabled.Reproduction
Flowbite version and System Info
The text was updated successfully, but these errors were encountered: