Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use ubuntu lts (jammy 22.04) #347

Closed
wants to merge 1 commit into from

Conversation

qkdreyer
Copy link
Contributor

@qkdreyer qkdreyer commented Dec 7, 2022

Summary

This PR fixes/implements :

Checklist

  • I followed the guidelines in CONTRIBUTING guide
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

@qkdreyer
Copy link
Contributor Author

bump @mistraloz

@mistraloz
Copy link
Collaborator

Same as others PR =) (to tell you all, i was sick on december : to much mail during my own outage xD).
I'm very appreciate this PR, but i will not merge it on v4 because of changing the base release is a breaking change. We need to find a way to allow that.

We are working onto V5. Maybe i can find some time to rearrange V5 branch in january and allow your change on it. It's urgent for you ?

@qkdreyer
Copy link
Contributor Author

Hey :) yeah sure let's merge this into a v5 branch. not that urgent but highly appreciated!

@mistraloz
Copy link
Collaborator

Did you saw that in CI testing?
#60 57.41 ## Your distribution, identified as "jammy", is not currently supported, please contact NodeSource at https://github.com/nodesource/distributions/issues if you think this is incorrect or would like your distribution to be considered for support

Ok i just saw your last commit. You removed old node version ? (it's acceptable for v5)

@qkdreyer
Copy link
Contributor Author

yeah, sadly jammy is not compatible with node 10/12

@qkdreyer
Copy link
Contributor Author

I can't create the v5 branch btw and change this PR base branch

@qkdreyer
Copy link
Contributor Author

qkdreyer commented Jan 3, 2023

I've rebased that branch on v4, you can review it and create the v5 branch @mistraloz

@qkdreyer
Copy link
Contributor Author

ping @mistraloz

@qkdreyer
Copy link
Contributor Author

any news?

@qkdreyer
Copy link
Contributor Author

ping @mistraloz

@mistraloz
Copy link
Collaborator

Hello and sorry. I missed of time. I explained here the work for v5 #359 and i will starting it. I will try to integrate your work firstly (as alpha version).

@qkdreyer
Copy link
Contributor Author

qkdreyer commented May 4, 2023

any news? 👀

@stale
Copy link

stale bot commented Jul 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please update it if any action still required.

@stale stale bot added the stale Issues inactives for a while (automatically) label Jul 3, 2023
@stale
Copy link

stale bot commented Jul 10, 2023

This issue has been automatically closed because it has not had recent activity. Please, reopen if you need.

@stale stale bot closed this Jul 10, 2023
@qkdreyer
Copy link
Contributor Author

Any news @mistraloz ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues inactives for a while (automatically)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulnerabilities found
2 participants