Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer programming code review on my-portfolio project #5

Open
LUCASFRANKINC opened this issue Jun 13, 2023 · 0 comments
Open

Peer programming code review on my-portfolio project #5

LUCASFRANKINC opened this issue Jun 13, 2023 · 0 comments

Comments

@LUCASFRANKINC
Copy link

Hello Faiz 🥇 ,

First of all, bravo 😮 🎆 on the design of the site. We can really acknowledge that way more than perfection has been applied on this project. We cannot assume the essence of good UI, perfect design and the hardwork displayed to bring the site to life.

Secondly, as a team, we have concluded that the design is working perfectly, though we would like to add on some few touches to better it 💯.

Having reviewed the content of your project and the UI, we have come up with strategic ideas that could in a way better the design and also the semantics of your projects. These are listed below ⬇️

  • Kindly consider implementing a div wrapper to hold the body of your site. This will help in aligning your content to implement flex and grid for easier positioning 💪🏽 .
  • Please try to use the semantic html tags such as section's, article's which will in turn reduce the number of div's that you apply in a certain block. This will ensure that your code is neat and self-explanatory ♻️ .
  • Please note that once you implement the required attribute on a form element, you really do not require to use a pattern on it. This is a good practice to let the html handle the validation unless you have a better way to validate 😀 .
  • Kindly apply the use of flex and grids over the position to ensure that the flow does not break down in different viewports. Please avoid hard-coded pixels and also if you have to implement positioning, please use percentages which will ensure that all the displays are visible as expected 🥂 .

Cheers and happy coding 😀 . From team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant