Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Shopify URL protocols in slater.config.js #93

Open
bomanimc opened this issue May 24, 2020 · 0 comments
Open

Handle Shopify URL protocols in slater.config.js #93

bomanimc opened this issue May 24, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@bomanimc
Copy link

Hi! I'm new to Slater, and I noticed that I stumbled for a while trying to understand why my uses of npm run deploy:development and slater watch ere failing given my credentials with the error:

slater v1.8.0

watch development theme

built in 2.734s
  > index.css
  > index.js
(node:15238) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'asset' of undefined
    at theme.sync.then.then.catch (/usr/local/lib/node_modules/slater/index.js:156:57)
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:15238) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:15238) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:15238) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'asset' of undefined
    at theme.sync.then.then.catch (/usr/local/lib/node_modules/slater/index.js:156:57)
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:15238) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)

I eventually noticed that the issue was that I listed my Shopify URL in slater.config.js as https://dial-up-digital-development.myshopify.com instead of dial-up-digital-development.myshopify.com.

I think it would be ideal from a developer experience for syncing to not fail if the protocol is added in the URL. It also seems that Theme Kit handles protocols in Shopify URLs.

@iamkevingreen iamkevingreen added the enhancement New feature or request label Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants