Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before publishing to npm, build and package JS/CSS assets #8

Open
iamkevingreen opened this issue Apr 13, 2019 · 5 comments
Open

Before publishing to npm, build and package JS/CSS assets #8

iamkevingreen opened this issue Apr 13, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request theme Anything related to the starter theme itself.

Comments

@iamkevingreen
Copy link
Member

Only impacts first upload of theme, would be nice to have the compiled version by default and not need to run npm run start to see the latest update of styles/js

@iamkevingreen iamkevingreen added the enhancement New feature or request label Apr 13, 2019
@iamkevingreen iamkevingreen self-assigned this Apr 13, 2019
@estrattonbailey
Copy link
Member

@iamkevingreen I think this was taken care of a while back, not sure by who: https://github.com/the-couch/slater/blob/master/packages/theme/package.json#L8

@iamkevingreen
Copy link
Member Author

I mean when you first zip and manually import the theme into shopify.

@estrattonbailey estrattonbailey self-assigned this May 20, 2019
@estrattonbailey estrattonbailey added the theme Anything related to the starter theme itself. label Jun 2, 2019
@estrattonbailey estrattonbailey removed their assignment Jun 2, 2019
@wardpenney
Copy link
Contributor

@iamkevingreen I believe you are using the npm start script when that is used for development and watching. If you want to deploy, use the npm deploy task, which includes a fresh build.

@estrattonbailey recommend this one be closed

@estrattonbailey
Copy link
Member

Thanks @wardpenney!

Kev and I talked about this offline and what he really means is that before we publish to npm, we should build JS/CSS so that when a user jumps in for the first time they won't have to do a full upload.

I was confused at first as well, haha.

@estrattonbailey estrattonbailey changed the title Build css/js in npm deploy task Before publishing to npm, build and package JS/CSS assets Jun 5, 2019
@iamkevingreen
Copy link
Member Author

@wardpenney yeah, the intention here is not to deploy into the debut theme (which comes with shopify out of the box), we don't want the additional bloat of that theme since deploying doesn't remove files from a theme it only overrides them.

Instead we should prepare a zip file that is an easy upload for first time use, perhaps some npm package for building a compressed file prior to our npm pushes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request theme Anything related to the starter theme itself.
Projects
None yet
Development

No branches or pull requests

3 participants