-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for timestamp function #206
Labels
good first issue
Good for newcomers
Comments
Hey @fpetkovski I've a good understanding of tests in GO . Can you please assign this to me so I could work on this ? |
Could you provide guidance on the modifications I should make? |
Closed
Closed by #366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The timestamp function is currently broken and we've decided to revert it in #204.
The correct way to implement it is to return each sample's timestamp instead of the step timestamp. This will make sure that samples returned due to the engine lookback have their original timestamp in the output.
One way to do it is to detect the presence of a the
timestamp
function in a query (maybe through an optimizer), and push it down into the vector selector. The selector will then store timestamps directly into the values of output vectors.The text was updated successfully, but these errors were encountered: