-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
topK/bottomK
edge behavior mismatch between thanos engine and the native engine
#254
Comments
RickDeb2004
added a commit
to RickDeb2004/promql-engine
that referenced
this issue
May 11, 2023
I wonder: is topk/bottomk even distributable? |
Does this testcase make sense?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The topK and bottomK operators return errors on the native engine when the first argument (k) is empty on all cases and in the Thanos engine, we only return an error if the second argument is not empty.
Ex: the following expression returns error on the native engine but not in the new engine:
Adding a simple check to return an error always if the arg is nil does not work as it breaks some distributed queries tests where some shards can be empty.
The text was updated successfully, but these errors were encountered: