Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Chromecast support #289

Closed
playday3008 opened this issue May 17, 2021 · 18 comments · May be fixed by #296
Closed

[Feature Request] Chromecast support #289

playday3008 opened this issue May 17, 2021 · 18 comments · May be fixed by #296
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@playday3008
Copy link

Cast as YouTube Music (as smartphone version)
Or cast as "tab" (as Chrome/Edge etc.)

@Araxeus
Copy link
Collaborator

Araxeus commented May 17, 2021

I will try working on that, but only if you are prepared to test it out abit when its ready,
because I dont personally have one 😅

@playday3008
Copy link
Author

No problem

@Araxeus
Copy link
Collaborator

Araxeus commented May 18, 2021

@playday3008

Ok here is the first draft version:
https://github.com/Araxeus/youtube-music/tree/chromecast

Its on a branch in my fork. can you clone and run yarn start on it?

run yarn install before launching to install new dependencies

if not, and you are using windows - I can build and upload binaries for you if needed

After enabling the plugin and restarting the app (and allowing electron/youtube-music in firewall), it should theoretically connect to any device it finds - and play there the same music you play in the app

@playday3008
Copy link
Author

if not, and you are using windows - I can build and upload binaries for you if needed

You can set up GitHub Actions or build it for me, bcoz im on Windows

@Araxeus
Copy link
Collaborator

Araxeus commented May 18, 2021

@playday3008
Copy link
Author

Not working @Araxeus

@Araxeus
Copy link
Collaborator

Araxeus commented May 18, 2021

I have uploaded a new version (same gdrive folder)

I added a message box with current status (since you cant see console output)

Also The first button in 'Plugins' menu should be now 'Update Chromecast List'

can you download again and try updating and see what the message box output looks like?

@playday3008
Copy link
Author

Well, device found
image
But search output incorrect
image

P.S. Maybe you have Telegram to contact?

@Araxeus
Copy link
Collaborator

Araxeus commented May 18, 2021

I've fixed that toString, and added more checks. you can download from folder again 😝

Does only find the device after clicking the Update button in the menu? or before?
Does it say anything when playing songs / pausing songs?

By the way try to register device only once, because there isn't currently any check for duplication (it adds device every time you find one)

Telegram Username @Oksidoxi

@BelgarionNL
Copy link

so how do you cast. I have the latest version in windows and I dont see the plugin.

@Araxeus
Copy link
Collaborator

Araxeus commented Jun 23, 2021

@BelgarionNL it hasn't been released yet (there is an open pull request)

Love your username BTW, is it from the Belgariad/Malloreon or just random? :P

@BelgarionNL
Copy link

yea its from the belgariad ofcourse :)

@kultawat
Copy link

How can I test this on mac?

@Beersteddy
Copy link

@Araxeus
Hi
Is there any update on cast functionality?

I can se cast icon on latest 1.14.0 but clicking it really does completely nothing.
image

Tried 1.12.1 from your gdrive but I don't see in there any option to cast at all

@cmcinroy
Copy link

cmcinroy commented Dec 7, 2021

@Beersteddy I just noticed the same icon. Turns out it's from the underlying Youtube Music service. Presumably, the reason it does nothing in this app is that in a browser it brings up the menu to select the target cast device.

It would be interesting to know whether this new feature in the base service gets us any closer to casting from an electron app.

@Araxeus
Copy link
Collaborator

Araxeus commented Dec 7, 2021

It would be interesting to know whether this new feature in the base service gets us any closer to casting from an electron app.

No it sadly doesn't, their internal implementation doesn't work because electron doesn't support[1][2] the chrome.cast api

#509 will remove this button since it doesn't work.

PR #296 could be re-opened in the future (it mostly works)

@Araxeus
Copy link
Collaborator

Araxeus commented Dec 7, 2021

@Beersteddy

Tried 1.12.1 from your gdrive but I don't see in there any option to cast at all

Thats because you would need to clone the branch from the Pull Request to test the latest changes (gdrive was a very early alpha version)

Might have other bugs since its based on an old version of the app

@JellyBrick JellyBrick added the enhancement New feature or request label Oct 7, 2023
@JellyBrick
Copy link
Collaborator

Duplicate of #113

@JellyBrick JellyBrick marked this as a duplicate of #113 Oct 7, 2023
@JellyBrick JellyBrick closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2023
@JellyBrick JellyBrick added duplicate This issue or pull request already exists enhancement New feature or request and removed enhancement New feature or request labels Oct 7, 2023
@ArjixWasTaken ArjixWasTaken mentioned this issue Apr 6, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants