Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With ignore_fail: true, in the event that the upstream hasn't advanced, the fork-sync action *still takes 4 minutes* to complete #170

Open
maze88 opened this issue May 28, 2024 · 0 comments

Comments

@maze88
Copy link

maze88 commented May 28, 2024

The sync-fork action is hardcoded to retry 4 times, with a 60 second delay. Although this is useful in certain cases, it is unnecessarily slow in other cases.

Classic example use case

  • Automatically sync my fork from the upstream, on a certain schedule (e.g. nightly).
  • If the upstream has new commits, everything works fine.
  • But if the upstream hasn't got new commits, then the issue occurs.

Expected behavior

If the upstream hasn't got new commits, then fail fast - without retries, etc.

Suggested solution approach

Make the action idempotent - before creating the PR, add a check that there even is a diff between the Head and Base references.

@maze88 maze88 changed the title With ignore_fail: true, in the event that the upstream hasn't advanced, the fork-sync action *still takes 4 minutes* With ignore_fail: true, in the event that the upstream hasn't advanced, the fork-sync action *still takes 4 minutes* to complete May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant