[No GBP] Slime people will not be eaten be slimes #83340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
Fix
comfyorange
added a commit
that referenced
this pull request
May 20, 2024
Chowder-McArthor
pushed a commit
to Chowder-McArthor/desertbus13
that referenced
this pull request
Jun 6, 2024
## About The Pull Request This PR readds a missing faction check that got lost during basic mob conversion. Partially at least, previous, it ensured that FACTION_NEUTRAL was a one way faction, protecting slimes from other things, while keeping all the other factions via a check that fully reimplemented `faction_check` in a less efficient way. Rather then reimplementing this behaviour, I have just made them check for the FACTION_SLIME, similarly how regal rats skip converting already converted frogs and cockroaches. So in short, slimes once again will not attack slime people, but everything else is fair game once they get hungry (except for people who are in their friend list). I am not fully happy with this solution, but I would rather not make a new list by subtracting FACTION_NEUTRAL every time they check someone. ## Why It's Good For The Game One of the unique features of slime people was that slimes consider them friends and family. This PR brings this back this feature I forgot to reimplement. Fixes tgstation#83324 ## Changelog :cl: fix: Slimes will no longer consider feeding upon slime people /:cl:
Chowder-McArthor
pushed a commit
to Chowder-McArthor/desertbus13
that referenced
this pull request
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR readds a missing faction check that got lost during basic mob conversion. Partially at least, previous, it ensured that FACTION_NEUTRAL was a one way faction, protecting slimes from other things, while keeping all the other factions via a check that fully reimplemented
faction_checkin a less efficient way. Rather then reimplementing this behaviour, I have just made them check for the FACTION_SLIME, similarly how regal rats skip converting already converted frogs and cockroaches.So in short, slimes once again will not attack slime people, but everything else is fair game once they get hungry (except for people who are in their friend list).
I am not fully happy with this solution, but I would rather not make a new list by subtracting FACTION_NEUTRAL every time they check someone.
Why It's Good For The Game
One of the unique features of slime people was that slimes consider them friends and family. This PR brings this back this feature I forgot to reimplement.
Fixes #83324
Changelog
馃啈
fix: Slimes will no longer consider feeding upon slime people
/:cl: