Slimes attack and try to eat slimepeople #83324
Comments
|
This is caused by me forgetting to port the faction check to the hunt behaviour, sorry! However, reimplementing this is unclear. I dont want to reimplement the old behaviour, which circumvented the dedicated faction checking proc, by removing the neutral faction from slimes and compared what was left. How much trouble would it cause, if slimes lost the neutral faction, I wonder. |
|
It looks like, the main issue would be aggressive Neutral mobs would attack them, along with shuttle turrets. |
ShizCalev
pushed a commit
that referenced
this issue
May 20, 2024
## About The Pull Request This PR readds a missing faction check that got lost during basic mob conversion. Partially at least, previous, it ensured that FACTION_NEUTRAL was a one way faction, protecting slimes from other things, while keeping all the other factions via a check that fully reimplemented `faction_check` in a less efficient way. Rather then reimplementing this behaviour, I have just made them check for the FACTION_SLIME, similarly how regal rats skip converting already converted frogs and cockroaches. So in short, slimes once again will not attack slime people, but everything else is fair game once they get hungry (except for people who are in their friend list). I am not fully happy with this solution, but I would rather not make a new list by subtracting FACTION_NEUTRAL every time they check someone. ## Why It's Good For The Game One of the unique features of slime people was that slimes consider them friends and family. This PR brings this back this feature I forgot to reimplement. Fixes #83324 ## Changelog :cl: fix: Slimes will no longer consider feeding upon slime people /:cl:
Chowder-McArthor
pushed a commit
to Chowder-McArthor/desertbus13
that referenced
this issue
Jun 6, 2024
## About The Pull Request This PR readds a missing faction check that got lost during basic mob conversion. Partially at least, previous, it ensured that FACTION_NEUTRAL was a one way faction, protecting slimes from other things, while keeping all the other factions via a check that fully reimplemented `faction_check` in a less efficient way. Rather then reimplementing this behaviour, I have just made them check for the FACTION_SLIME, similarly how regal rats skip converting already converted frogs and cockroaches. So in short, slimes once again will not attack slime people, but everything else is fair game once they get hungry (except for people who are in their friend list). I am not fully happy with this solution, but I would rather not make a new list by subtracting FACTION_NEUTRAL every time they check someone. ## Why It's Good For The Game One of the unique features of slime people was that slimes consider them friends and family. This PR brings this back this feature I forgot to reimplement. Fixes tgstation#83324 ## Changelog :cl: fix: Slimes will no longer consider feeding upon slime people /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Summary
While being transformed in any slimeperson type you expect to not be attacked by your jelly pals, but they do. And they also try to eat you even when not that hungry. Started after the refactor in #82176
Round ID:
Testmerges:
Reproduction:
The text was updated successfully, but these errors were encountered: