Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if all uses of difficult_words are correct #73

Open
alxwrd opened this issue Dec 8, 2018 · 3 comments
Open

Investigate if all uses of difficult_words are correct #73

alxwrd opened this issue Dec 8, 2018 · 3 comments
Labels
chore An issue that shouldn't be too difficult to complete, but requires time priority: medium

Comments

@alxwrd
Copy link
Member

alxwrd commented Dec 8, 2018

As reported in #70 and fixed in #71, a difficult word is: not in the easy_word_set and more than one syllable.

This is not true for Gunning Fog, and might not be for other calculations that rely upon difficult_words(). Need to verify the other formulas that use difficult_words.

@alxwrd alxwrd added the chore An issue that shouldn't be too difficult to complete, but requires time label Jun 25, 2019
@TiredFalcon
Copy link

The Dale-Chall readability formula does not use syllables counts to identify difficult words, but only the easy_words list.

Therefore, the count of easy words for Dale-Chall should be computed with:

count = word_count - self.difficult_words(text, syllable_threshold=0)

@alxwrd
Copy link
Member Author

alxwrd commented Jun 3, 2020

@TiredFalcon thank you for this! 🎉 I've raised #127.

@dogweather
Copy link

dogweather commented Jul 20, 2022

Note also, difficult_words() only returns the count of distinct difficult words, not the total in the text. IMO this is a bug and has been giving wrong results: #192 #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore An issue that shouldn't be too difficult to complete, but requires time priority: medium
Development

No branches or pull requests

3 participants