Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peer dependencies for react-text-mask to include React 17 #1038

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samheutmaker
Copy link

Fixes #1032

@therk
Copy link

therk commented May 9, 2021

@msafi can you please review and merge? Our CI breaks on any warning and we just React 17 upgrade.

@samheutmaker
Copy link
Author

I created a fork that specifies React 17 as a peer dependency. The packages is here

@dougmorin
Copy link

This would be great to have merged in. What's the hold-up with this? This is currently the only package that fails in my build simply because this is missing from the peer dependencies.

@lucascampelo
Copy link

Can any maintainer prioritize this issue ?

@emilyjablonski
Copy link

Would love to see this merged in!

@Reyescult
Copy link

I got bit by this issue today. This is the only 3rd-party package I use in my custom component library, and of course, it's the one that brings the whole thing down.

@recs182
Copy link

recs182 commented Dec 8, 2021

It would be great if it was merged.

Copy link

@recs182 recs182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add support to react 17 without breaking changes.

@rpowis
Copy link

rpowis commented Feb 2, 2022

Any reason why this can't be merged if it's been approved? We just added it to our design system and it broke the build.

@mdeeter
Copy link

mdeeter commented Feb 16, 2022

Please merge.

@mdeeter
Copy link

mdeeter commented Apr 4, 2022

so, now that this is merged, how to kick off a new version?

@brightsider
Copy link

@mdeeter I think npm run react:publish

@recs182
Copy link

recs182 commented May 25, 2022

For those who still has this problem, there is a solution, not ideal but works just fine.

image


Source: https://twitter.com/housecor/status/1528820339026821121?s=20&t=2xbr4sm28xDeZeRDsrsxJw

@maxbronnikov10
Copy link

guys please merge this

@hahuma
Copy link

hahuma commented Jul 4, 2022

Hey guys, please merge this PR it's the only lib that fails in my projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix peer dependency please for react