Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fjord] Add FastLZ compression into L1CostFunc + Refactor #177

Merged
merged 15 commits into from
May 27, 2024

Conversation

pcw109550
Copy link
Member

@pcw109550 pcw109550 force-pushed the pcw109550/fjord/fastlz-l1costfunc branch from c907ab0 to ebf4aea Compare May 24, 2024 09:09
@pcw109550 pcw109550 force-pushed the pcw109550/fjord/fastlz-l1costfunc branch 3 times, most recently from cfb5423 to e434298 Compare May 24, 2024 09:36
@pcw109550 pcw109550 force-pushed the pcw109550/fjord/fastlz-l1costfunc branch from e434298 to 38ad705 Compare May 24, 2024 09:43
@ImTei
Copy link
Member

ImTei commented May 25, 2024

Looks good 👍 but we have few things to deduplicate and cleanup code.
In erigon-lib/opstack/rollup_cost.go,

  • extractL1GasParamsPreEcotone and extractL1GasParamsPostEcotone have some duplicated lines with extractL1GasParamsLegacy and extractL1GasParamsEcotone. we can reuse code.
  • New L1 cost logic must be applied to existing other methods: L1Cost, l1CostHelper, L1CostFnForTxPool

@pcw109550
Copy link
Member Author

Looks good 👍 but we have few things to deduplicate and cleanup code. In erigon-lib/opstack/rollup_cost.go,

  • extractL1GasParamsPreEcotone and extractL1GasParamsPostEcotone have some duplicated lines with extractL1GasParamsLegacy and extractL1GasParamsEcotone. we can reuse code.
  • New L1 cost logic must be applied to existing other methods: L1Cost, l1CostHelper, L1CostFnForTxPool

Fixed at #179

@pcw109550 pcw109550 merged commit 5150ef2 into op-erigon May 27, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants