-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What's the reason @types are being added as dependencies as opposed to peerDependencies? #729
Comments
This has been discussed before in #110 (my latest thoughts). It basically boils down to we don't want to force peer dependency warnings about types for non-TS users and by using very permissive types (we only restrict the minimum version, any newer version is allowed), the types are supposed to be flattened to the top. In most cases, removing |
Hey, we are currently looking into adding this library into our codebase and the functionality is great. From previous experiences with other ts libraries in our codebase, we would have expected the types to be devDependencies. |
Hi @ksjogo. The main reason we use a We are a typescript library and as such our TS users expect our dependencies to be installed and as they form part of our public API then That said, I'm strongly considering moving them into |
This should be resolved in v8.0.0 where we no longer install type dependencies. |
react-hooks-testing-library/package.json
Lines 53 to 55 in ca13ed9
This is causing multiple React declarations errors in our codebase, e.g.
The text was updated successfully, but these errors were encountered: