New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toBeChecked suggested to replace check for aria-checked="mixed" #43
Comments
hmm interesting, wasn't aware of that. I'd say there are a few options
I'd prefer to do 1 or 2, but don't have the cycles right now if you'd like to open a PR. |
Yup, I thought something along the lines of no. 1, could work. Will propose it in jest-dom. |
We now have So this issue can be now about making the eslint plugin aware of this for as a replacement for |
Care to open a PR @gnapse ? |
eslint-plugin-jest-dom
version: 2.1.0Relevant code or config
What you did:
I want to assert that the checked status is "mixed". It generally is only "true" or "false", but it can also be "mixed".
What happened:
The rule to prefer
toBeChecked
kicked in, but I cannot assert what I want with that custom matcher.Suggested solution:
I think we need to either make an exception here with
"mixed"
, but that would also be a problem, because for legibility in my test I'd like to use the same kind of assertion as my checkbox state changes. So it would not be ideal to usetoBeChecked
for some cases but not others with only a couple of lines of difference.Or maybe there's nothing to do here. The "mixed" case is so rare, that maybe what we need to do is to disable the rule for that line. But I still wanted to discuss.
The text was updated successfully, but these errors were encountered: