-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behavior of waitForElementToBeRemoved when first call throws #1093
Open
Comments
make-github-pseudonymous-again
added a commit
to contribulate/dom-testing-library
that referenced
this issue
Jan 21, 2022
This commit includes a regression test. Fixes testing-library#1093.
The documentation is contradicting itself already. It only says that it'll throw on So documentation should be clarified as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@testing-library/dom
version: 8.11.2Problem description:
There is currently no exception catching for the initial call inside
waitForElementToBeRemoved
. When that call ofcallback
throws, instead of getting the errorError('The element(s) given to waitForElementToBeRemoved are already removed...')
we will get the error thrown from the callback, even when it is aTestingLibraryElementError
. This contradicts the documented behavior:Suggested solution:
See #1094.
The text was updated successfully, but these errors were encountered: