-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 7.1 Support Question #9
Comments
ActiveRecord::InternalMetadata no longer inherits from ActiveRecord::Base: rails/rails@93ddf33 Reference: testdouble#9
@thewatts any plans to open PR? I have checked and your update works well for our project. Btw. I'm also enjoying using this gem 💪. |
Hey @thewatts, I've taken over ownership of this gem. Definitely looking into what it will take to have support for Rails 7.1. The changes to If you'd like to make a PR addressing those changes, that would be greatly appreciated. Otherwise, it's something I'm hoping to take care of soon. |
Hey there! Sorry - I didn't see the notification about your message! I don't mind taking my code and submitting a PR :) Hold tight |
ActiveRecord::InternalMetadata no longer inherits from ActiveRecord::Base: rails/rails@93ddf33 Reference: testdouble#9
👋 Hey there!
Love all the OSS work that Test Double does - and all of the thought leadership that comes out of the crew.
I was working with a project to update it to 7.1, and the project uses this gem (and it's very helpful!)
I found the issue at hand, specifically -
ActiveRecord::InternalMetadata
no longer inherits fromActiveRecord::Base
: rails/rails@93ddf33Not a difficult fix - but I suppose I'm curious if this project is still something actively used by the Test Double team.
If this isn't the recommended path anymore - totally fine, and I'd love to know what the team prefers. If it is, however, I'm more than happy to submit a PR.
Thanks again for all you do!
The text was updated successfully, but these errors were encountered: