-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeline: fix kWh values and column layout for miles (#3846) #3847
base: master
Are you sure you want to change the base?
Conversation
Add the kWh multiplication needed for driving and parking when using miles Use the same index value for the Range Diff column so the layout is the same with miles or kilometers
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
May I propose to use convert_km instead of CASE in the SQL statement? Just to be consistent. |
convert_km divides by 1.60934 so the proper fix for charging looks to be to not use convert_km at all
Still looking at how to fix the parking query
|
This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions. |
Are you planning a separate PR or include in this one? Also please update your branch with latest master |
Can we assume the parking query is correct for metric users? |
This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions. |
Yes, both the driving and parking kWh are the same in km units if the convert_km is removed so that looks like a good solution to me. |
This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
efficiency is stored as kwh/km, therefore convert_km seems not to be needed at all in these calculations, agree.
@dyxyl - do you want to update your PR based on latest master or should I open a follow up PR ?
I don't have a PR for this -- it was @sdwalker who originated it. |
😆 - sorry. @sdwalker, would you like to update the PR ? |
Add the kWh multiplication needed for driving and parking when using miles
Use the same index value for the Range Diff column so the layout is the same with miles or kilometers