Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[terraform-ibm-observability-da] Add a test to test existing resources #7

Closed
ocofaigh opened this issue Mar 25, 2024 · 4 comments
Closed
Assignees

Comments

@ocofaigh
Copy link
Member

ocofaigh commented Mar 25, 2024

Add a test to test the following 2 use cases:

  • using existing COS and COS buckets
  • using existing COS and KMS key (so the DA creates new COS bucket and encrypts them with an existing KMS key)

Take the same approach that was taken in the SCC DA test -> https://github.com/terraform-ibm-modules/terraform-ibm-scc-da/blob/be22e36f2ad23a26af718d4a34b65f9b821a6ca7/tests/pr_test.go#L112

@kierramarie
Copy link
Contributor

For the first test is it supposed to be one bucket or multiple buckets for one or all the services (e.g. log archive, and activity tracker)?

@kierramarie
Copy link
Contributor

Test has been implemented and is in the process of being tested and debugged.

@kierramarie
Copy link
Contributor

Found a bug in Instances solution where the bucket_config_map is being set to null when existing resources are used, however its length is checked several times causing errors. A fix will be addressed in the PR.

@kierramarie
Copy link
Contributor

PR has been merged. Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants