Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tensorflow "Text generation with an RNN" tutorial out of date #75945

Closed
abisdbest opened this issue Sep 17, 2024 · 7 comments · May be fixed by tensorflow/text#1313
Closed

Tensorflow "Text generation with an RNN" tutorial out of date #75945

abisdbest opened this issue Sep 17, 2024 · 7 comments · May be fixed by tensorflow/text#1313
Assignees
@tilakrayal
Labels
comp:model Model related issues stale This label marks the issue/pr stale - to be closed automatically if no activity stat:awaiting response Status - Awaiting response from author type:support Support issues

Comments

@abisdbest
Copy link

I was taking a look at the tutorial on generating text with an RNN from the tensorflow website (https://www.tensorflow.org/text/tutorials/text_generation), and clicked the option to run on Google Colab. But when I tried running the full code I got overwhelmed with a multitude of errors. I thought I might have been doing something wrong, so I searched online, but found out that you are supposed to be able to just run the code without modification.
I figured it could just be that the way the new versions of tensorflow worked may have changed.

Would be very helpful to me if it could be fixed
many thanks
@tilakrayal tilakrayal added the type:docs-bug Document issues label Sep 18, 2024
@tilakrayal
Copy link
Contributor

@abisdbest,
Thank you for reporting the issue. I observed the same that the code is failing in tensorflow v2.17. Please allow some time to deep dive into the issue. Thank you!

@tilakrayal tilakrayal added WIP comp:model Model related issues labels Sep 18, 2024
@tilakrayal
Copy link
Contributor

tilakrayal commented Sep 19, 2024 •
edited
Loading

@abisdbest,
Hi, By default the colab notebook is using tensorflow v2.17 which contains keras3.0 which was causing the error. Could you please try to import keras2.0 with the below commands.

!pip install tf-keras

import tf_keras as keras

Also I have modified some steps and then the code was executed without error/fail. Kindly find the gist of it here.

Thank you!

@tilakrayal tilakrayal added type:support Support issues stat:awaiting response Status - Awaiting response from author and removed type:docs-bug Document issues WIP labels Sep 19, 2024
@tilakrayal tilakrayal mentioned this issue Sep 19, 2024
Open
@abisdbest
Copy link
Author

thank you very much!

@google-ml-butler google-ml-butler bot removed the stat:awaiting response Status - Awaiting response from author label Sep 19, 2024
@tilakrayal
Copy link
Contributor

tilakrayal commented Sep 20, 2024 •
edited
Loading

@abisdbest,
I have created the PR for the changes required. tensorflow/text#1313
Could you please confirm if the issue is resolved. if yes, please feel free to move this issue to closed status. Thank you!

@tilakrayal tilakrayal added the stat:awaiting response Status - Awaiting response from author label Sep 20, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 7 days with no activity. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale This label marks the issue/pr stale - to be closed automatically if no activity label Sep 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2024

This issue was closed because it has been inactive for 7 days since being marked as stale. Please reopen if you'd like to work on this further.

@github-actions github-actions bot closed this as completed Oct 6, 2024
@google-ml-butler Google-ML-Butler
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tilakrayal tilakrayal

Labels
comp:model Model related issues stale This label marks the issue/pr stale - to be closed automatically if no activity stat:awaiting response Status - Awaiting response from author type:support Support issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modifying the text_generation.ipynb tilakrayal/text
2 participants
@tilakrayal @abisdbest