-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mempool/p2p: Research implications of peer disconnect based on ResponseCheckTx #9546
Closed
Labels
stale
for use by stalebot
Comments
9 tasks
jmalicevic
changed the title
Research and document:- The use case for such behaviour;- Implications for the security and correctness model (how does the application know that it is this particular peer that should be removed, is this scenario not covered already by other layers in Tendermint, etc.);- What other changes in other parts of Tendermint should the implementation of this require;- If solution/problem still seem valuable, propose an implementation path taking into account potential need to refactor and change the p2p layer itself to support this.
mempool/p2p: Research the removal of bad peers based on CheckTx return code
Oct 13, 2022
jmalicevic
changed the title
mempool/p2p: Research the removal of bad peers based on CheckTx return code
mempool/p2p: Research implications of peer disconnect based on ResponseCheckTx
Oct 13, 2022
jmalicevic
added
the
priority
A high-priority, high-level item to be shown on the priorities project board
label
Oct 13, 2022
thanethomson
removed
the
priority
A high-priority, high-level item to be shown on the priorities project board
label
Dec 22, 2022
21 tasks
This was referenced Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As mentioned in #7918 and #2185, it might be of interest to disconnect from a peer when receiving transactions that could never have been valid.
Before implementing this behaviour we want to look into more details of such a behaviour. Namely:
The text was updated successfully, but these errors were encountered: