Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aws_launch_template instead of launch configuration? #11

Open
itsdalmo opened this issue Jan 3, 2019 · 6 comments
Open

Use aws_launch_template instead of launch configuration? #11

itsdalmo opened this issue Jan 3, 2019 · 6 comments

Comments

@itsdalmo
Copy link
Contributor

itsdalmo commented Jan 3, 2019

The new t3 instances launch with unlimited mode being enabled by default, and there is no way to disable it using launch configurations. It seems one needs to use aws_launch_template to have control over the setting. Launch templates are as far as I can gather the "new launch configuration".

@itsdalmo
Copy link
Contributor Author

itsdalmo commented May 8, 2019

Will wait for 0.12 before attempting this one as it will likely require complex counts and if statements.

@itsdalmo itsdalmo closed this as completed May 8, 2019
@itsdalmo itsdalmo reopened this May 8, 2019
@itsdalmo
Copy link
Contributor Author

Tested this as part of 0.12-refactoring (code is currently in my stash). Ran into a number of bugs with aws_launch_template variables that do not support a null value from Terraform, which caused actual crashes. This was with version 2.12.0 of the AWS provider.

Also, for loops within template directives %{} seem to be causing a diff on every run, which makes 0.12.0 unusable for now. Will attempt again in a few releases.

@evanstachowiak
Copy link
Contributor

Any updates on this now that 0.12 is merged?

@itsdalmo
Copy link
Contributor Author

itsdalmo commented Oct 15, 2019

The terraform resource seemed very buggy when I last attempted to use it so I have not given it another try yet unfortunately. Is there a particular feature you are looking for that requires launch templates?

@evanstachowiak
Copy link
Contributor

Yes, I would like to use the unlimited CPU credit setting which is only available with launch templates. In general, they're also just nicer to use and copy around if necessary.

I've been using them for a while now in other modules and have not seen any issues.

@itsdalmo
Copy link
Contributor Author

Great to hear @evanstachowiak; seems like launch templates is where AWS wants us to go, so I think it would be great to make the switch if it finally works well in Terraform now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants