Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add width and height html attr in img tag #576

Open
Utwo opened this issue May 17, 2021 · 2 comments
Open

Add width and height html attr in img tag #576

Utwo opened this issue May 17, 2021 · 2 comments
Labels
core This issue involves changes inside the core module of the generators enhancement New feature or request Hacktoberfest

Comments

@Utwo
Copy link
Contributor

Utwo commented May 17, 2021

Whenever we have width and height in pixels set in styles on element node, add the values to the width and height attributes in image tag without unit.

@Utwo Utwo added enhancement New feature or request core This issue involves changes inside the core module of the generators labels May 17, 2021
@chavda-bhavik
Copy link
Contributor

Hey @Utwo, to implement this we have to add attributes here https://github.com/teleporthq/teleport-code-generators/blob/development/packages/teleport-uidl-resolver/src/html-mapping.ts#L21, and anywhere else we have to work?

@JayaKrishnaNamburu
Copy link
Member

Hey @chavda-bhavik this is kind of core thing, needs little more changes and primarily some investigation of the best way to handle. I got your invitation for fixing #545 issue. I will set things for you there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core This issue involves changes inside the core module of the generators enhancement New feature or request Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants