Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telekom-profile-menu logoutHandler #2348

Open
EdsonT-Systems opened this issue Sep 5, 2024 · 4 comments
Open

telekom-profile-menu logoutHandler #2348

EdsonT-Systems opened this issue Sep 5, 2024 · 4 comments
Labels
bug Something isn't working feature New component features and enhancements

Comments

@EdsonT-Systems
Copy link

EdsonT-Systems commented Sep 5, 2024

Scale Version
Latest

Framework and version
Angular latest with auto-generated scale wrapper packages

Current Behavior
The logoutHandler function does not work well with angular navigation

Expected Behavior Code Reproduction
A clear and concise description of what you expected to happen.

I haven't found a solution to make the logout function work correctly so that the navigation functions properly and the other components have enough time to render.

The ts and the template look like this:

image

  • Case 1 Logout bottom(scale-telekom-profile-menu):

Ui: image

-The behavior is that it redirects you and displays the console msg, and it also executes the internal logic. However, when the navigation occurs, the surrounding components do not render correctly.

Example:

image

  • Case 2 Logout bottom(normal botton)

Ui:
image

-However, when the same action is triggered by a click event (in parentheses), it executes without any issues, performing the same action and rendering the rest of the components properly.

Example:

image

@tshimber @acstll @felix-ico @amir-ba

@EdsonT-Systems EdsonT-Systems added the bug Something isn't working label Sep 5, 2024
@EdsonT-Systems
Copy link
Author

After further checks, I noticed that the "logoutHandler" function is outside the Angular's control zone, which is causing the navigation to break. I also realized this while looking at the following warning:

Captura de pantalla 2024-09-05 160516

Would it be possible to change the logoutHandler so that it functions as a method, similar to how (scale-focus) works for inputs, for example? This way, it wouldn’t exit Angular’s control zone.

@tshimber
Copy link
Contributor

hi @EdsonT-Systems ! sorry, I've had vacation prev week till today. I'll discuss this all with my colleague and will write you back.

@EdsonT-Systems
Copy link
Author

Oh, no worries! I hope you enjoyed your vacation. I’ll stay tuned for your response once you hear back from them :) @tshimber

@EdsonT-Systems
Copy link
Author

Guys, is it possible for you to change the logoutHandler property to a method? I know I was initially going to do it myself, but my team and I are currently at full capacity because we need to release the app to production, and I don’t have the time right now to develop it without being familiar with the tools yet. Once the workload eases a bit, I can continue to collaborate and help with whatever I can. @tshimber @amir-ba

@amir-ba amir-ba added the feature New component features and enhancements label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New component features and enhancements
Projects
None yet
Development

No branches or pull requests

4 participants
@amir-ba @tshimber @EdsonT-Systems and others