Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing the topmost notification prevents other notifications from hiding #28813

Open
kolayne opened this issue Jan 1, 2025 · 2 comments · May be fixed by #28816
Open

Closing the topmost notification prevents other notifications from hiding #28813

kolayne opened this issue Jan 1, 2025 · 2 comments · May be fixed by #28816
Labels
bug

Comments

@kolayne
Copy link

kolayne commented Jan 1, 2025

Steps to reproduce

  1. Receive multiple notifications, so that more than one is displayed in the corner
  2. Hover the topmost notification (for the bottom corner) or the bottommost notification (for the top corner)
  3. Either close the notification via right-click or the X button, or open the message with the hovered notification from another device.

Expected behaviour

As the notification is gone from under the cursor, other notifications start fading out

Actual behaviour

Nothing happens until a cursor passes through notifications again. This is likely because Notification::leaveEventHook is not triggered in any of the cases from point 3.

Operating system

Arch Linux, i3 version 4.24

Version of Telegram Desktop

5.9.2

Installation source

Other (unofficial) source

Crash ID

No response

Logs

No response
@kolayne kolayne added the bug label Jan 1, 2025
kolayne added a commit to kolayne/tdesktop that referenced this issue Jan 1, 2025
@kolayne
Fix handling of notification disappearing under cursor
c771a4b 
Previously, notifications disappearing under cursor (e.g., because closed
manually or open from another device) did not notify the manager
properly, as the leaveEventHook was not triggered. This could lead to
notifications staying around when not supposed to (see telegramdesktop#28813).

This commit fixes that by explicitly notifying manager when the
notification widget disappears under the cursor.

Fixes telegramdesktop#28813.
@kolayne kolayne linked a pull request Jan 1, 2025 that will close this issue
Open
@ilya-fedin
Copy link
Contributor

This is likely because Notification::leaveEventHook is not triggered in any of the cases from point 3.

It must be triggered. If it's not, then it's either a bug on Qt or your WM side.

@kolayne
Copy link
Author

kolayne commented Jan 1, 2025

It is not related to my WM. Here I reproduce it on Windows 11, using Telegram 5.9, downloaded and installed from the official website:

2025-01-01.19-13-19.mp4

kolayne added a commit to kolayne/tdesktop that referenced this issue Jan 2, 2025
@kolayne
Fix handling of notification disappearing under cursor
83e0403 
Previously, notifications disappearing under cursor (e.g., because closed
manually or open from another device) did not notify the manager
properly, as the leaveEventHook was not triggered. This could lead to
notifications staying around when not supposed to (see telegramdesktop#28813).

This commit fixes that by explicitly notifying manager when the
notification widget disappears under the cursor.

Fixes telegramdesktop#28813.
kolayne added a commit to kolayne/tdesktop that referenced this issue Jan 2, 2025
@kolayne
Fix handling of notification disappearing under cursor
89a8c6f 
Previously, notifications disappearing under cursor (e.g., because closed
manually or open from another device) did not notify the manager
properly, as the leaveEventHook was not triggered. This could lead to
notifications staying around when not supposed to (see telegramdesktop#28813).

This commit fixes that by explicitly notifying manager when the
notification widget disappears under the cursor.

Fixes telegramdesktop#28813.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix handling of notification disappearing under cursor kolayne/tdesktop
2 participants
@ilya-fedin @kolayne