Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker and/or Firebase? #78

Open
aaronosher opened this issue Jun 13, 2018 · 8 comments
Open

Docker and/or Firebase? #78

aaronosher opened this issue Jun 13, 2018 · 8 comments

Comments

@aaronosher
Copy link

Hey, so I'm already Dockerizing quill (pretty much done with that) and I'll submit a PR once I'm happy. I was wondering would be interested in a firebase port, using Real-time Database or Cloud Firestore instead of MongoDB. I probably wouldn't port it over to use the firebase SDK on the frontend, just to use cloud functions instead, but that's probably dependent on how much time I have to kill.

Thoughts?

@ravirahman
Copy link

ravirahman commented Jun 14, 2018 via email

@aaronosher
Copy link
Author

That's fair, and I've been digging a bit more around the source code and can see how for larger events it could become a fairly large issue. Moreover, in trying to adapt quill to better suite HackNotts, I've run into a handful of quirks that I can't live without fixing. I'm probably going to take a week or so at some point in July/August and port quill over to Angular 6 with Cloud Firestore and Cloud functions. Angular 6 mainly because I never worked with AngularJS and don't really see a point in learning, and partially because the angular SDK for firebase is only for Angular 2+. Firebase because I'm used to it, and it's cheap.

@aaronosher
Copy link
Author

I'll PR my Dockerfile/Docker-Compose config in the next week or so.

@ehzhang
Copy link
Contributor

ehzhang commented Jun 15, 2018

I've been digging a bit more around the source code and can see how for larger events it could become a fairly large issue.

What particular points do you see being performance bottlenecks? I don't see a reason why anyone would or even should encounter performance problems for a fairly straightforward/lightweight CRUD application with barely any models, even if you have multiple thousands of users and thousands on thousands of hits.

@aaronosher
Copy link
Author

What particular points do you see being performance bottlenecks?

The bottlenecks come in the sense that Cloud Functions aren't optimized to be used as a REST API for everything, and it's a lot more costly compared to hitting Firestore directly through the SDK–especially as you get charged twice, once for the function call, and then also for the Firestore or RDB hit. In any app where I use cloud functions as an API point is notably slower than direct Firestore SDK calls.

@ehzhang
Copy link
Contributor

ehzhang commented Jun 18, 2018

Ah, my misunderstanding - I read your message as if this application as is (no cloud functions) had performance bottlenecks.

@jay-khatri
Copy link

@aaronosher any developments on dockerizing quill? If you're able to share a Dockerfile, that'd be great!

@aaronosher
Copy link
Author

aaronosher commented Aug 7, 2018

@jay-khatri My summer seems to have run away from me. If you head over to the hacksocnotts fork on the feature/dockerize branch, there are new Dockerfile, docker-compose.yml and .dockerignore files. As far as I can tell they work as intended. Configure the docker-compose.yml file to your liking and run $ docker-compose up it should work.

I've linked it here: https://github.com/HackSocNotts/quill/tree/feature/dockerize

Edit: I also just submitted a PR to add the Docker functionality #86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants