Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm create svelte-ux@latest on Windows #288

Closed
techniq opened this issue Mar 11, 2024 · 10 comments
Closed

Fix npm create svelte-ux@latest on Windows #288

techniq opened this issue Mar 11, 2024 · 10 comments

Comments

@techniq
Copy link
Owner

techniq commented Mar 11, 2024

Looks to be an issue handling Window paths...

image

tested works on Mac

image

See discussion

@techniq
Copy link
Owner Author

techniq commented Mar 26, 2024

@jycouet thoughts?

@jycouet
Copy link
Collaborator

jycouet commented Mar 27, 2024

I have to look somewhere else, I think I fixed it already 🤔
RN I can't really look, I'll do in a few days.

Ping me again if I forget.

@techniq
Copy link
Owner Author

techniq commented Mar 27, 2024

No rush. Thanks @jycouet

@Carsten-R
Copy link

Still the same issue with version 0.3.3 on windows

@jycouet
Copy link
Collaborator

jycouet commented Apr 1, 2024

Actually, I didn't managed it... I just did this in another package:
https://github.com/jycouet/kitql/blob/main/packages/create-kitql/bin.js#L195-L201

Here is the same function in svelte-ux: https://github.com/techniq/svelte-ux/blob/main/packages/create-svelte-ux/bin.js#L191-L193

I'm sure it's possible to have this working in all OS... But would be easier to have a windows to try things out.
Someone wanna give a shoot? (Or should I boot my windows? ^^)

@29th-Day
Copy link
Contributor

I wrote a fix #353 for windows but I currently cannot test it other OSs

@techniq
Copy link
Owner Author

techniq commented May 18, 2024

Tested on Mac. Thanks @29th-Day!

image

@techniq
Copy link
Owner Author

techniq commented May 18, 2024

Just waiting on CI to catch up on the queue, then will publish as 0.4.0 (still use npm create svelte-ux@latest)

@techniq
Copy link
Owner Author

techniq commented May 18, 2024

Done. Thanks again @29th-Day (Gerald)

@techniq techniq closed this as completed May 18, 2024
@jycouet
Copy link
Collaborator

jycouet commented May 18, 2024

Nice, thx a lot 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants