Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onInit emits iconPickerSelect event #64

Open
janschab opened this issue Nov 24, 2022 · 0 comments
Open

onInit emits iconPickerSelect event #64

janschab opened this issue Nov 24, 2022 · 0 comments

Comments

@janschab
Copy link

hello,
onInit hook calls this.iconPickerSelect.emit(this.iconPicker);. Does it serve any purpose?
Imo event should only be sent when there is a icon change.

ngOnInit() {
    this.iconPicker = this.iconPicker || this.ipFallbackIcon || 'fa fa-user-plus';
    this.iconPickerSelect.emit(this.iconPicker);
}

I would be grateful if I could contribute and do PR that will make emitting event optional in onInit.

@Input() emitEventOnInit: boolean = true;

ngOnInit() {
    this.iconPicker = this.iconPicker || this.ipFallbackIcon || 'fa fa-user-plus';

    if (this.emitEventOnInit) {
        this.iconPickerSelect.emit(this.iconPicker);
    }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant