Adaptions for use within Team Spatzenhirn #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
da sind so ca 1000 reformatting changes drin (auch wenn man whitespace changes ausblendet), kann man das entfernen, für einfacheres review? |
ottojo
requested changes
Jul 19, 2021
|
In src/rqt_image_view/ratio_layouted_frame.cpp und include/rqt_image_view/ratio_layouted_frame.h sind gar keine changes, oder? wenn ja -> reverten |
ottojo
approved these changes
Aug 10, 2021
|
@authaldo das baut momentan nicht auf rolling, vermutlich braucht man ros-visualization#68 und ros-visualization#62. Könntest du das hier auf den upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: replaced image_transport with a normal subscription and added the option of unsubcribing if the view is not visible