Fix/a instead of clickable #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update upstream
fixes #398 This is necessary because it's useful to use regular clicking and allow for example opening in a new tab. todo: test this properly (maybe it accidentally put a text-decoration)
|
@Haroenv Thanks for the fix. There are packages that might depend on the clickable-row class (tdt-input for example). Do you mind reverting the changes to script.js and make a new pull request against the development branch? |
|
Okay, I'll rebase and merge towards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #398
This is necessary because it's useful to use regular clicking and allow for example opening in a new tab.
todo: test this properly (maybe it accidentally put a text-decoration)