Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up String handling #13

Open
birkenfeld opened this issue Jul 8, 2017 · 2 comments
Open

Clean up String handling #13

birkenfeld opened this issue Jul 8, 2017 · 2 comments

Comments

@birkenfeld
Copy link
Collaborator

Since Haskell doesn't use string slices, there's a lot of places with unnecessary .to_string() use, and functions with String instead of &str in the signature.

@tcr
Copy link
Owner

tcr commented Jul 10, 2017

It just occured to me, I bet clippy would identify a ton of this excessive heap use. (One more reason to exclude parser-c-core from the root crate).

@birkenfeld
Copy link
Collaborator Author

I was kind of dreading running Clippy for now... 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants