Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests in src/dynamic-import/catch don't fail if the error is not thrown #4373

Open
nicolo-ribaudo opened this issue Jan 10, 2025 · 0 comments

Comments

@nicolo-ribaudo
Copy link
Member

Those templates are meant to test what error is thrown, but they pass if no error is thrown because they don't assert that the error happens. They only assert properties of the error if the error is indeed thrown.

I noticed this while writing import.defer tests, please don't fix it until when the import.defer PRs are merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant