Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uli-website]: fix code blocks styling in mdx files #558

Open
aatmanvaidya opened this issue May 7, 2024 · 3 comments
Open

[uli-website]: fix code blocks styling in mdx files #558

aatmanvaidya opened this issue May 7, 2024 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers investigate level:ticket An issue that describes a ticket (initiative>feature>ticket) priority:medium role:frontend size:2pt

Comments

@aatmanvaidya
Copy link
Collaborator

aatmanvaidya commented May 7, 2024

A while ago, we had added some custom formatting and styling to how code blocks should be displayed on the uli-website.

Here is a blog (page) on uli-website that has some code blocks referenced in them.

Here is all the work previously done

GitHub Issue - #382
PR - #395

The changes made to the UI styling of code blocks have seem to be broken

image

  • Investigate into what caused this issue, mostly it will have to be with the external library being used.
  • An ideal solution is to write a custom code block without any support of a library. This way we have entire control over the changes and it doesn't add an extra dependency to the code base.
@aatmanvaidya aatmanvaidya added bug Something isn't working good first issue Good for newcomers investigate size:2pt priority:medium role:frontend level:ticket An issue that describes a ticket (initiative>feature>ticket) labels May 7, 2024
@dennyabrain
Copy link
Contributor

@hardik-pratap-singh tagging for your visibility.

@hardik-pratap-singh
Copy link
Contributor

Hey @dennyabrain @aatmanvaidya,
I want to take this issue.
Please assign it to me.

@aatmanvaidya
Copy link
Collaborator Author

hi @hardik-pratap-singh , assigning the issue to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers investigate level:ticket An issue that describes a ticket (initiative>feature>ticket) priority:medium role:frontend size:2pt
Projects
None yet
Development

No branches or pull requests

3 participants