Some nitpicking for unifying the todos #635
Labels
Comments
|
Would be great if you could be more exact on which apps that are inconsistent (last point), since we would love to get it fixed ;) |
|
Alright, here's a list from the stable ones. I'm talking about the input field not being trimmed; the actual data is saved correctly, trimmed:
(On chrome, safari) (Stephen was here) |
|
Thanks for the list, @chenglou! We'll probably all be taking stabs at these. Feel free to claim some for yourself, if you're up for it! |
passy
added a commit
to passy/todomvc
that referenced
this issue
Aug 5, 2013
This was referenced Aug 5, 2013
Merged
passy
added a commit
to passy/todomvc
that referenced
this issue
Aug 26, 2013
Squashed commit of the following: commit 3527bd3 Author: abhinav <[email protected]> Date: Mon Aug 26 16:32:40 2013 +0530 added space commit 6028ac9 Author: abhinav <[email protected]> Date: Mon Aug 26 16:09:04 2013 +0530 indentation and spacing for comments. Removed chrome = 1 commit 8d14fad Author: abhinav <[email protected]> Date: Thu Aug 22 12:48:08 2013 +0530 Added cancel functionality on escape key by using a temporary shadow observable which updates the title only on a non-escape blur from the text box. commit 33d6d68 Author: abhinav <[email protected]> Date: Wed Aug 21 19:32:54 2013 +0530 the editing property is removed from the todo object and moved into the root. Also - rolled back the silliness in the last edit. commit 37eec81 Author: abhinav <[email protected]> Date: Wed Aug 21 18:50:49 2013 +0530 removed the durandal.css style sheet altogether commit 1b2df76 Author: abhinav <[email protected]> Date: Wed Aug 21 18:43:43 2013 +0530 created a shadow field for title , so that if the user closes the page while editing, the title is not affected, only the shadow is change which gets discarded. commit 71877d5 Author: abhinav <[email protected]> Date: Fri Aug 9 16:44:16 2013 +0530 Now trimming on edit as well. commit 0ccbc8c Author: abhinav <[email protected]> Date: Fri Aug 9 16:15:37 2013 +0530 added back modalDialog.js commit 4f655ec Author: abhinav <[email protected]> Date: Fri Aug 9 16:15:12 2013 +0530 sending filter parameter via shared shell commit 33fd5cf Author: abhinav <[email protected]> Date: Fri Aug 9 16:14:38 2013 +0530 wrapped in anonymous closure commit 6d8af2c Author: abhinav <[email protected]> Date: Fri Aug 9 16:01:00 2013 +0530 using the url routing logic to control the tasks filter. commit 29c6dcf Author: abhinav <[email protected]> Date: Fri Aug 9 16:00:17 2013 +0530 Removed the loading animation commit c32cd03 Author: abhinav <[email protected]> Date: Fri Aug 9 15:15:20 2013 +0530 converted indentation to tabs across js and html commit 50fe848 Author: abhinav <[email protected]> Date: Fri Aug 9 15:08:21 2013 +0530 removed unused files from durandal library set. commit 08cf6f9 Author: abhinav <[email protected]> Date: Thu Aug 8 16:20:10 2013 +0530 typo corrected. commit 5625807 Author: abhinav <[email protected]> Date: Thu Aug 8 16:16:15 2013 +0530 updated the documentation and learn.json files for links and comments commit 93d0842 Author: abhinav <[email protected]> Date: Thu Aug 8 15:37:18 2013 +0530 moved durandal to the dependency-examples folder commit 764b5e2 Author: abhinav <[email protected]> Date: Thu Aug 8 12:45:30 2013 +0530 Added Durandal framework commit 71f080c Author: Addy Osmani <[email protected]> Date: Tue Aug 6 18:11:51 2013 +0100 Minor changes to readme, changelog in prep of release commit 7456c07 Author: Pascal Hartig <[email protected]> Date: Tue Aug 6 19:06:53 2013 +0200 Added Angular+Firebase example to changelog commit 78ee321 Author: Stephen Sawchuk <[email protected]> Date: Tue Aug 6 12:28:54 2013 -0400 remove funnyfacejs from learn.json. commit 167aea5 Author: Stephen Sawchuk <[email protected]> Date: Tue Aug 6 11:23:17 2013 -0400 update to todomvc-common#0.1.8. commit 11dabd2 Merge: 4244d8b fefb382 Author: Sindre Sorhus <[email protected]> Date: Tue Aug 6 08:19:19 2013 -0700 Merge pull request tastejs#652 from passy/homepage-1.2 Updated homepage for 1.2 commit fefb382 Author: Pascal Hartig <[email protected]> Date: Tue Aug 6 17:01:26 2013 +0200 Updated homepage for 1.2 commit 4244d8b Author: Addy Osmani <[email protected]> Date: Tue Aug 6 14:41:54 2013 +0100 Adding Polymer to changelog commit 1f989ae Author: Sindre Sorhus <[email protected]> Date: Tue Aug 6 15:05:03 2013 +0200 Remove funnyface from readme commit 910cf9a Author: Addy Osmani <[email protected]> Date: Tue Aug 6 14:03:42 2013 +0100 Removing o_O implementation. Has not been updated in forever commit 6d5c1f0 Author: Greg Lobinski <[email protected]> Date: Tue Aug 6 14:40:35 2013 +0200 Backbone naming tweaks Closes tastejs#610 Fixes tastejs#605 commit 3debb37 Merge: 9f55c02 3db7131 Author: Pascal Hartig <[email protected]> Date: Tue Aug 6 05:39:26 2013 -0700 Merge pull request tastejs#641 from Foxandxss/angular-patch AngularJS - Add a check for changes to prevent unneeded saves. commit 9f55c02 Author: Stephen Sawchuk <[email protected]> Date: Tue Aug 6 14:36:00 2013 +0200 fix yui .focus() spec deviation RE tastejs#635 Closes tastejs#646 commit 3df87c7 Author: MStumpp <[email protected]> Date: Tue Aug 6 14:27:35 2013 +0200 Updated to meteor release 0.6.4 Closes tastejs#630 commit 7cb4d0e Author: Sindre Sorhus <[email protected]> Date: Tue Aug 6 14:24:18 2013 +0200 index.html - head/body indentation commit 39a16fa Author: Sindre Sorhus <[email protected]> Date: Tue Aug 6 14:13:44 2013 +0200 Tweak formatting in codestyle.md commit a7278fe Author: Sindre Sorhus <[email protected]> Date: Tue Aug 6 14:10:32 2013 +0200 Remove gittip button commit bf3fef7 Author: Sindre Sorhus <[email protected]> Date: Tue Aug 6 14:06:54 2013 +0200 Remove Chrome Frame thingy commit 3f696d4 Merge: fd3f4d0 be84165 Author: Sindre Sorhus <[email protected]> Date: Tue Aug 6 04:58:58 2013 -0700 Merge pull request tastejs#599 from joyvuu-dave/backbone_marionette_require removes un-used (and un-needed) shim for backbone.localStorage commit fd3f4d0 Merge: 2efa903 300b76c Author: Addy Osmani <[email protected]> Date: Tue Aug 6 03:50:56 2013 -0700 Merge pull request tastejs#648 from tastejs/polymer-update Updating to latest official Polymer TodoMVC implementation commit 300b76c Author: Pascal Hartig <[email protected]> Date: Mon Aug 5 18:22:45 2013 +0200 polymer: code style update commit 2efa903 Merge: f7db323 edde223 Author: Addy Osmani <[email protected]> Date: Mon Aug 5 13:03:35 2013 -0700 Merge pull request tastejs#649 from passy/backbone-trimming Backbone: trim edits commit edde223 Author: Pascal Hartig <[email protected]> Date: Mon Aug 5 19:56:02 2013 +0200 backbone: trim on edit (ref tastejs#635) commit aad9dd5 Author: Pascal Hartig <[email protected]> Date: Mon Aug 5 17:45:06 2013 +0200 polymer: bower_components GC commit 7a6824f Author: Addy Osmani <[email protected]> Date: Mon Aug 5 15:43:26 2013 +0100 Updating to latest official Polymer TodoMVC implementation commit f7db323 Author: Sindre Sorhus <[email protected]> Date: Mon Aug 5 00:30:59 2013 +0200 Chrome Frame is no more commit 8c48866 Author: Pascal Hartig <[email protected]> Date: Sun Aug 4 17:23:28 2013 +0200 firebase-angular: refactor controller commit 20100b5 Author: Pascal Hartig <[email protected]> Date: Sun Aug 4 17:14:24 2013 +0200 firebase-angular: refactored todo filtering commit 246ebee Merge: e82b3c2 8eeb1f4 Author: Addy Osmani <[email protected]> Date: Sun Aug 4 07:59:31 2013 -0700 Merge pull request tastejs#638 from chenglou/upgrade Upgrade to React 0.4, fully compliant with specs commit e82b3c2 Merge: 2ec5dc1 6defd80 Author: Addy Osmani <[email protected]> Date: Sun Aug 4 07:50:36 2013 -0700 Merge pull request tastejs#633 from anantn/firebase Realtime: Addition for Firebase as a realtime framework commit 2ec5dc1 Author: Stephen Sawchuk <[email protected]> Date: Fri Aug 2 15:13:37 2013 -0400 fix spine .focus() spec deviation. commit 92328d5 Merge: ae3b53c 4fccfbf Author: Sindre Sorhus <[email protected]> Date: Thu Aug 1 12:21:01 2013 -0700 Merge pull request tastejs#644 from BorisKozo/bugfixes Marionette - Changes for issue tastejs#642 commit ae3b53c Author: Pascal Hartig <[email protected]> Date: Thu Aug 1 19:30:22 2013 +0200 Add routing badge to Vanilla example commit 4fccfbf Author: Boris Kozorovitzky <[email protected]> Date: Wed Jul 31 23:02:56 2013 +0300 Bumped versions Fixed issue tastejs#642 Couple of minor bug fixes commit 6f094c7 Merge: 401846d 5218856 Author: Addy Osmani <[email protected]> Date: Wed Jul 31 00:32:58 2013 -0700 Merge pull request tastejs#639 from paulmillr/topics/update-brunch-chaplin Update Brunch with Chaplin. commit 5218856 Author: Paul Miller <[email protected]> Date: Tue Jul 30 05:46:46 2013 +0300 Fix missing bower.json. commit 3db7131 Author: Jesus Rodriguez <[email protected]> Date: Mon Jul 29 16:54:24 2013 +0200 Add an if to prevent unneeded saves commit 4147067 Author: Paul Miller <[email protected]> Date: Mon Jul 29 01:33:40 2013 +0300 Chaplin-brunch: do real model-level filtering, get rid of stuff. commit 466147a Author: Paul Miller <[email protected]> Date: Sun Jul 28 04:04:55 2013 +0300 Don't use CSS for filtering in Chaplin-brunch. commit b4e7bc9 Author: Paul Miller <[email protected]> Date: Sat Jul 27 22:50:31 2013 +0300 Update Brunch with Chaplin. 1. Add Bower integration. Since Brunch automatically concatenates all Bower stuff, we don’t need bower_components in repository (added to .gitignore, except of todomvc-common). 2. Update Brunch to 1.7. * Added automatic source maps generation, source maps are in repo too. 3. Update Chaplin to 0.10. * Remove `chaplin` module, switch to global variable. * Switch to new declarative events format. * Switch to controller compositions instead of static controllers. * Remove `application` since Chaplin now has this functionality by default. commit 8eeb1f4 Author: Cheng Lou <[email protected]> Date: Fri Jul 26 20:12:17 2013 -0400 directly set director as dep commit 401846d Merge: b299ed3 f3a0719 Author: Sindre Sorhus <[email protected]> Date: Fri Jul 26 05:43:33 2013 -0700 Merge pull request tastejs#637 from Roland1975/gh-pages refactor to reflect logic on line 62 commit f3a0719 Author: Roland1975 <[email protected]> Date: Fri Jul 26 13:33:34 2013 +0200 refactor to reflect logic on line 62 commit b299ed3 Author: Stephen Sawchuk <[email protected]> Date: Thu Jul 25 20:50:47 2013 -0400 fix jquery .focus() spec deviation. commit 24c22e2 Merge: 26bdbb2 2d92e70 Author: Sindre Sorhus <[email protected]> Date: Thu Jul 25 17:02:30 2013 -0700 Merge pull request tastejs#636 from glebm/patch-1 Remove ternary expressions commit 2d92e70 Author: Gleb Mazovetskiy <[email protected]> Date: Fri Jul 26 01:52:57 2013 +0200 Remove ternary expressions A more readable and scalable approach commit 1b16a19 Author: Cheng Lou <[email protected]> Date: Thu Jul 25 17:06:41 2013 -0400 Upgrade to React 0.4, fully compilant - Compilant with coding style. - Removed app.css. No need anymore since we freed id. - Render info footer separately (specs). - Tweak footer to make it pass jshint when compiled: - {''} after 'left'. - {''} around `clear completed`. - Breaking style for footer clearButton, `>` on the same line. - Rename cx and put it in Utils. - Routing with director. - Change some keyUp to keyDown (specs). - Strip form tags (specs? Referred to the stable ones). - Trim after editing item. - Manually autofocus (attribute not supported in ie9). - Input focus now triggers as a callback (because of batch rendering). - Controlled input. - Gutter at 80. - Class `completed` trim whitespace. - Remove bind. commit 6defd80 Author: Anant Narayanan <[email protected]> Date: Mon Jul 22 12:30:28 2013 -0700 Add Firebase + AngularJS realtime example commit 26bdbb2 Merge: ba4b149 1617459 Author: Sindre Sorhus <[email protected]> Date: Fri Jul 19 17:56:32 2013 -0700 Merge pull request tastejs#632 from gsydonkey/gh-pages Update index.html commit 1617459 Author: gsydonkey <[email protected]> Date: Sat Jul 20 06:18:42 2013 +0700 Update index.html Updated YUI seed file commit ba4b149 Author: cam song <[email protected]> Date: Sun Jul 14 12:20:00 2013 +0200 Close tastejsGH-629: Update YUI. commit 777a74a Merge: 5a2db4c c4fdbfc Author: Sindre Sorhus <[email protected]> Date: Thu Jul 11 02:31:54 2013 -0700 Merge pull request tastejs#628 from Roland1975/gh-pages Refine selector by providing a context commit c4fdbfc Author: Roland <[email protected]> Date: Wed Jul 10 11:41:01 2013 +0200 Use find() on selector commit 5a2db4c Merge: e149f24 13d6a87 Author: Addy Osmani <[email protected]> Date: Tue Jul 9 03:21:32 2013 -0700 Merge pull request tastejs#618 from snize/gh-pages Fixing tastejs#617 commit e149f24 Merge: 9a2ad38 4869d71 Author: Addy Osmani <[email protected]> Date: Tue Jul 9 03:18:33 2013 -0700 Merge pull request tastejs#627 from passy/angular-esc angularjs: add escape behavior commit 9a2ad38 Merge: ba9a2fc 780f4c8 Author: Pascal Hartig <[email protected]> Date: Tue Jul 9 02:47:57 2013 -0700 Merge pull request tastejs#625 from schubertha/gh-pages SAPUI5: bug fixes (tab preserves todo changes, enter always finishes editing) commit 780f4c8 Author: Harald Schubert <[email protected]> Date: Fri Jul 5 17:56:02 2013 +0200 SAPUI5: bug fixes (tab preserves todo changes, enter always finishes editing) commit 4869d71 Author: Pascal Hartig <[email protected]> Date: Mon Jul 8 20:41:05 2013 +0200 angularjs: add escape behavior commit ba9a2fc Author: Stephen Sawchuk <[email protected]> Date: Mon Jul 8 14:18:03 2013 -0400 (flight) fixes tastejs#626 - updated links. commit ecae4c3 Author: Pascal Hartig <[email protected]> Date: Mon Jul 8 09:19:51 2013 +0200 flight: enable evil mode for templating engine commit 87c5b34 Merge: c77cbff 9692112 Author: Pascal Hartig <[email protected]> Date: Fri Jul 5 07:41:17 2013 -0700 Merge pull request tastejs#624 from akudev/gh-pages SAPUI5: remove unneeded libraries from bootstrap commit 9692112 Author: Andreas Kunz <[email protected]> Date: Fri Jul 5 15:44:22 2013 +0200 sapui5: remove unneeded libraries from bootstrap commit c77cbff Author: Pascal Hartig <[email protected]> Date: Wed Jul 3 23:55:00 2013 +0200 sapui5: added learnbar, fixed style loading If the script loader is triggered after loading the stylesheet, some of our overrides don't apply. commit c2f442d Merge: e727203 39339df Author: Pascal Hartig <[email protected]> Date: Wed Jul 3 23:37:03 2013 +0200 Merge branch 'schubertha-gh-pages' into gh-pages commit 39339df Author: Pascal Hartig <[email protected]> Date: Wed Jul 3 23:36:41 2013 +0200 Added SAPUI to homepage, readme and changelog commit 7adf330 Author: Pascal Hartig <[email protected]> Date: Wed Jul 3 23:29:32 2013 +0200 sapui: bower-ified app and moved script loading commit 9d27117 Author: Pascal Hartig <[email protected]> Date: Wed Jul 3 23:15:23 2013 +0200 sapui5: code style fixes commit e7fbe33 Author: Harald Schubert <[email protected]> Date: Mon Apr 1 15:44:14 2013 +0200 TodoMVC using SAPUI5 commit 13d6a87 Author: Tomotsugu Kaneko <[email protected]> Date: Mon Jul 1 18:26:43 2013 +0900 Remove 'autopublish, insecure' packages and add code for security reasons. commit e727203 Author: Pascal Hartig <[email protected]> Date: Mon Jul 1 10:51:31 2013 +0200 Added jQuery Annotated Source to Learn Bar Ref tastejs#620 commit 4c725ca Merge: d82fcf5 50b52b2 Author: Sindre Sorhus <[email protected]> Date: Mon Jul 1 01:49:04 2013 -0700 Merge pull request tastejs#620 from danekszy/gh-pages Add jQuery annotated source commit 50b52b2 Author: Daniel Szymanek <[email protected]> Date: Mon Jul 1 03:25:33 2013 +0200 Add jQuery annotated source I suggest adding annotated source to the readme, as it seems helpful to understand how most of the things work. commit d82fcf5 Merge: d50f6e6 cceaffa Author: Pascal Hartig <[email protected]> Date: Sat Jun 29 15:06:00 2013 -0700 Merge pull request tastejs#616 from stephenplusplus/flight-bug (flight) bug with clearCompleted. commit cceaffa Author: Stephen Sawchuk <[email protected]> Date: Sat Jun 29 16:18:00 2013 -0400 (flight) fix clearCompleted bug. commit 757d0fc Author: Stephen Sawchuk <[email protected]> Date: Sat Jun 29 16:15:08 2013 -0400 (flight) code style changes. commit f588bcd Author: Tomotsugu Kaneko <[email protected]> Date: Fri Jun 28 18:16:26 2013 +0900 Fixed indentations. commit 006fbfa Author: Tomotsugu Kaneko <[email protected]> Date: Fri Jun 28 17:44:28 2013 +0900 fixes tastejs#617 - added Meteor.methods To call the `remove` method on the server side from the client side. commit eb2d7cb Author: Tomotsugu Kaneko <[email protected]> Date: Fri Jun 28 17:36:13 2013 +0900 added insecure package commit d50f6e6 Merge: c488f56 b9ffe3e Author: Addy Osmani <[email protected]> Date: Tue Jun 25 10:17:28 2013 -0700 Merge pull request tastejs#608 from tastejs/polymer Move Polymer about of labs commit b9ffe3e Author: Addy Osmani <[email protected]> Date: Tue Jun 18 10:21:51 2013 +0100 Moving Polymer out of labs commit c488f56 Merge: 575d1e6 57e70d6 Author: Stephen Sawchuk <[email protected]> Date: Tue Jun 18 16:46:37 2013 -0700 Merge pull request tastejs#609 from cujojs/cujojs-update Update to latest cujoJS releases commit 57e70d6 Author: Brian Cavalier <[email protected]> Date: Tue Jun 18 11:11:37 2013 -0400 Update to latest cujoJS releases: wire 0.10.0, curl 0.7.4, when 2.1.1 commit 575d1e6 Author: Stephen Sawchuk <[email protected]> Date: Tue Jun 18 12:02:59 2013 -0400 Fix Polymer homepage link in learn.json. commit 7b86797 Author: Stephen Sawchuk <[email protected]> Date: Tue Jun 18 11:44:29 2013 -0400 add Learn bar to labs -> Polymer. commit db9cb67 Merge: 5dd89f8 39781cc Author: Pascal Hartig <[email protected]> Date: Tue Jun 18 02:18:02 2013 -0700 Merge pull request tastejs#607 from acanby/fix_angularjs_readme Updated AngularJS links in the readme.md commit 5dd89f8 Author: Addy Osmani <[email protected]> Date: Tue Jun 18 10:13:06 2013 +0100 Updating learn.json with initial entry for Polymer commit 39781cc Author: Andrew Canby <[email protected]> Date: Tue Jun 18 19:06:01 2013 +1000 Updated AngularJS links in the readme.md commit 8959076 Author: Addy Osmani <[email protected]> Date: Tue Jun 18 09:58:02 2013 +0100 Fixes tastejs#576 - adds new Polymer TodoMVC implementation. Add entry to the homepage commit e82d6e4 Author: Pascal Hartig <[email protected]> Date: Tue Jun 18 01:05:24 2013 +0200 Updated link to Montage Quick Start Fix tastejs#606 commit 27ce25f Author: Pascal Hartig <[email protected]> Date: Mon Jun 17 22:23:51 2013 +0200 Added React to changelog commit 9bb0646 Merge: f22dbf8 37589b3 Author: Pascal Hartig <[email protected]> Date: Mon Jun 17 22:23:01 2013 +0200 Merge branch 'petehunt-react' into gh-pages commit 37589b3 Author: petehunt <[email protected]> Date: Wed May 29 23:11:09 2013 -0700 Initial add of React TodoMVC to labs React is a JavaScript library for building user interfaces by Facebook and Instagram. It powers many components on Facebook.com and all of Instagram.com is written with it. We have two TodoMVC examples checked into our repo: this one, which has no dependencies, and another one which showcases Backbone integration. I've only included the first one for now, if you guys think it's a good idea I can put out a PR for the one with Backbone integration. I read the contributing guide and I think this meets the standards, let me know if I missed something. commit f22dbf8 Author: Stephen Sawchuk <[email protected]> Date: Thu Jun 13 20:50:34 2013 -0400 fixes tastejs#601 - o_O jquery downgrade. commit f83a3ca Author: Stephen Sawchuk <[email protected]> Date: Thu Jun 13 16:53:07 2013 -0400 DUEL bug fixed, code style. commit b852875 Merge: 45a312d 966886b Author: Pascal Hartig <[email protected]> Date: Wed Jun 12 15:14:05 2013 -0700 Merge pull request tastejs#600 from theoptips/gh-pages fixed base.css input::-moz-placeholder commit 966886b Author: Dilys Sun <[email protected]> Date: Wed Jun 12 14:59:00 2013 -0700 fixed input::-moz-placeholder commit be84165 Author: Dave Riddle <[email protected]> Date: Tue Jun 11 15:55:34 2013 -0600 removes un-used (and un-needed) shim for backbone.localStorage commit 45a312d Author: Sindre Sorhus <[email protected]> Date: Sat Jun 8 21:03:40 2013 +0200 Fix link to SocketStream readme commit d5a4a92 Author: Stephen Sawchuk <[email protected]> Date: Sat Jun 8 10:15:11 2013 -0300 Correct angularjs homepage URL commit 3157437 Merge: d76a1f1 e811222 Author: Addy Osmani <[email protected]> Date: Sat Jun 8 02:24:55 2013 -0700 Merge pull request tastejs#595 from acanby/fix_angularjs_readme Fixed readme.md AngularJS links to .org instead of .com commit e811222 Author: Andrew Canby <[email protected]> Date: Sat Jun 8 15:28:28 2013 +1000 Fixed AngularJS links to .org instead of .com commit d76a1f1 Author: Stephen Sawchuk <[email protected]> Date: Tue Jun 4 20:06:22 2013 -0400 somajs code style + components -> bower_components. commit 3a6747c Author: Stephen Sawchuk <[email protected]> Date: Tue Jun 4 10:55:08 2013 -0400 epitome casing issue. commit 3b8c596 Merge: cc132b8 29f9c0a Author: Stephen Sawchuk <[email protected]> Date: Tue Jun 4 05:39:51 2013 -0700 Merge pull request tastejs#591 from stephenplusplus/epitome-bug Epitome Code Style + Spec Issue commit 29f9c0a Author: Stephen Sawchuk <[email protected]> Date: Mon Jun 3 23:01:13 2013 -0400 epitome hides footer when there are no todos. commit cc132b8 Merge: f15ab3f 513ef4d Author: Stephen Sawchuk <[email protected]> Date: Mon Jun 3 19:30:18 2013 -0700 Merge pull request tastejs#590 from callmehiphop/gh-pages Tweaked Montage lab to show the Learn sidebar. commit 513ef4d Author: callmehiphop <[email protected]> Date: Mon Jun 3 21:40:30 2013 -0400 Tweaks to allow the Learn side bar to not be destroyed commit f15ab3f Merge: 3aab99f 00dcae1 Author: Stephen Sawchuk <[email protected]> Date: Mon Jun 3 17:43:44 2013 -0700 Merge pull request tastejs#589 from callmehiphop/gh-pages Updated Enyo/Backbone lab to not remove the Learn sidebar. commit 00dcae1 Author: callmehiphop <[email protected]> Date: Mon Jun 3 20:30:21 2013 -0400 Updated enyo/backbone example to not kill the sidebar commit 3aab99f Author: Stephen Sawchuk <[email protected]> Date: Mon Jun 3 12:43:48 2013 -0400 rappidjs select all bug + code style. commit 45e8b94 Merge: 48b8ca7 ee9db31 Author: Stephen Sawchuk <[email protected]> Date: Mon Jun 3 09:14:11 2013 -0700 Merge pull request tastejs#573 from stephenplusplus/bbm backbone_marionette_require code style + spec comp. commit ee9db31 Author: Stephen Sawchuk <[email protected]> Date: Sun May 26 20:18:53 2013 -0400 backbone_marionette_require code style. commit 48b8ca7 Author: Stephen Sawchuk <[email protected]> Date: Sat Jun 1 19:59:51 2013 -0400 fixes tastejs#585 - update todomvc-common. commit 2b680e1 Author: Stephen Sawchuk <[email protected]> Date: Sat Jun 1 15:00:24 2013 -0400 maria uses bower for all dependencies. commit c18448e Author: Stephen Sawchuk <[email protected]> Date: Fri May 31 13:43:11 2013 -0400 closes tastejs#584 - backbone_marionette footer issues. commit ff32a65 Author: Stephen Sawchuk <[email protected]> Date: Fri May 31 12:27:47 2013 -0400 add somajs_require example to learn.json. commit 6422876 Merge: 0f75cb5 ba3ecf5 Author: Stephen Sawchuk <[email protected]> Date: Fri May 31 09:25:39 2013 -0700 Merge pull request tastejs#586 from somajs/somajs-module soma.js baseline update and added to module loader section commit ba3ecf5 Author: Romuald Quantin <[email protected]> Date: Fri May 31 17:17:25 2013 +0100 soma.js baseline update and added to module loader section commit 0f75cb5 Author: Addy Osmani <[email protected]> Date: Fri May 31 16:39:11 2013 +0100 Fixes tastejs#305 - bringing lower case consistency to app.Todos commit 834b79f Merge: 3af9f7b 10dee13 Author: Addy Osmani <[email protected]> Date: Fri May 31 08:27:30 2013 -0700 Merge pull request tastejs#553 from somajs/somajs soma.js v2 updates commit 10dee13 Author: Romuald Quantin <[email protected]> Date: Wed May 8 17:08:49 2013 +0100 soma.js version 2 in progress todo scope in models updated somajs update and comments somajs update soma.js and require.js added whitespace update main view hide update jshint errors update jshint errors update cleanup requirejs dependencies save on blur and remote persistent editing todomvc-common update on soma.js cleanup bower components in soma.js commit 3af9f7b Author: Pascal Hartig <[email protected]> Date: Thu May 30 23:52:52 2013 +0200 o_O: Added missing footer note commit 1dd3f1f Merge: cc045d6 3911ab5 Author: Addy Osmani <[email protected]> Date: Thu May 30 02:20:10 2013 -0700 Merge pull request tastejs#583 from epitome-mvc/epitome-0.3.1 fix for tastejs#577 commit 3911ab5 Author: Dimitar Christoff <[email protected]> Date: Thu May 30 10:08:19 2013 +0100 fix for tastejs#577 commit cc045d6 Author: Pascal Hartig <[email protected]> Date: Thu May 30 02:09:27 2013 +0200 Updated changelog commit 85a30be Merge: 3630eda b975647 Author: Pascal Hartig <[email protected]> Date: Wed May 29 17:06:58 2013 -0700 Merge pull request tastejs#575 from troopjs/troopjs Updated project to TroopJS 2.x commit 3630eda Merge: 27850ea fcc5981 Author: Stephen Sawchuk <[email protected]> Date: Wed May 29 13:47:13 2013 -0700 Merge pull request tastejs#579 from stephenplusplus/knockoutjs_require knockoutjs_require codestyle. commit fcc5981 Author: Stephen Sawchuk <[email protected]> Date: Wed May 29 16:45:00 2013 -0400 knockoutjs_require codestyle. commit 27850ea Merge: d59b261 ac44ecc Author: Stephen Sawchuk <[email protected]> Date: Wed May 29 13:30:10 2013 -0700 Merge pull request tastejs#578 from stephenplusplus/canjs_require restructured canjs_require + code style. commit ac44ecc Author: Stephen Sawchuk <[email protected]> Date: Wed May 29 16:26:36 2013 -0400 restructured canjs_require + code style. commit b975647 Author: Mikael Karon <[email protected]> Date: Mon May 27 11:46:58 2013 +0800 Updated project to TroopJS 2.x * Fix jshint errors. * Clean bower_components. * Update global, remove local learn.json. * Only edit when dblclick on `.view label`. * Update title from Template -> TroopJS. * Use .toggle (to simplify reading the code). * Add support for ESC_KEY during edit. * Escape title in template. * Use unminified versions of components. * Remove comments from html. * Remove `type` from script attribute. * Remove `baseUrl` from requirejs config. * Convert double to single quotes for javascript (in index.html). * Move troopjs -> troopjs_require and update the main index.html file to reflect updates in the framework. * Use `.focus()` instead of `.select()`. * Use Array natives for iteration. * Remove redundant package configuration. * `else` and `else if` on the same row as bracket. * No space before `:`. * Break `define` into multiple rows. * Simplify filter. * Stay consistent with anonymous function usage. * Add newlines. * Apply the same fix as in tastejs/todomvc@dca5107. * Don't quote keys. * Remove self evident comments. * Update storage code to _always_ restore UI on fail. commit d59b261 Author: Sindre Sorhus <[email protected]> Date: Mon May 27 20:07:58 2013 +0200 site: also fix the alt attr on Stephen and formatting and remove `and` commit 534a2c2 Author: Sindre Sorhus <[email protected]> Date: Mon May 27 20:06:08 2013 +0200 site: couldn't sleep because of the different url formats commit 4163de6 Author: Stephen Sawchuk <[email protected]> Date: Mon May 27 00:34:44 2013 -0400 (infobar) append link_groups if they exist. commit 609f6cc Author: Stephen Sawchuk <[email protected]> Date: Sat May 25 16:58:42 2013 -0400 updated todomvc-common to 0.1.7. commit e5dbc9b Author: Stephen Sawchuk <[email protected]> Date: Sat May 25 09:25:06 2013 -0400 updated todomvc-common; now using _ templates. commit c7d4020 Author: Addy Osmani <[email protected]> Date: Sat May 25 13:17:02 2013 +0200 Adding all team members to the homepage commit 318b974 Author: Addy Osmani <[email protected]> Date: Sat May 25 13:10:51 2013 +0200 Adding Stephen Sawchuk to the core team commit 0fc6831 Author: Pascal Hartig <[email protected]> Date: Fri May 24 18:18:58 2013 +0200 AngularJS-Perf: Applied trim patch commit dabdef2 Author: Pascal Hartig <[email protected]> Date: Fri May 24 18:14:06 2013 +0200 AngularJS+Require: Applied trim patch commit a9abf95 Merge: ae73f1c c462121 Author: Sindre Sorhus <[email protected]> Date: Thu May 23 07:04:26 2013 -0700 Merge pull request tastejs#571 from passy/angular-trim AngularJS: Trim todos on save commit c462121 Author: Pascal Hartig <[email protected]> Date: Thu May 23 13:19:27 2013 +0200 AngularJS: Trim todos on save commit ae73f1c Author: Pascal Hartig <[email protected]> Date: Thu May 23 13:05:13 2013 +0200 AngularJS: dependency example + angular-perf updated commit 1669496 Author: Pascal Hartig <[email protected]> Date: Thu May 23 13:01:30 2013 +0200 AngularJS: architecture example updated to 1.0.7 commit b7d77e8 Author: Pascal Hartig <[email protected]> Date: Thu May 23 12:58:52 2013 +0200 CanJS: Updated to 1.1.5 commit 66100a7 Merge: a71f2a3 63dfcd4 Author: Pascal Hartig <[email protected]> Date: Wed May 22 09:21:52 2013 -0700 Merge pull request tastejs#569 from stephenplusplus/gh-pages tastejs#568 Fix - insertAdjacentElement commit 63dfcd4 Author: Stephen Sawchuk <[email protected]> Date: Wed May 22 12:10:39 2013 -0400 tastejs#568 - insertAdjacentElement vs insertAdjacentHTML. commit a71f2a3 Merge: d54c743 3a4198d Author: Pascal Hartig <[email protected]> Date: Tue May 21 11:18:37 2013 +0200 Merge branch 'stephenplusplus-patch-1' into gh-pages commit 3a4198d Author: Stephen Sawchuk <[email protected]> Date: Tue May 21 02:06:43 2013 -0300 cujo.js -> cujoJS Seems they prefer the cujoJS phrasing over cujo.js. commit d54c743 Merge: b78a80a 05b1ce1 Author: Pascal Hartig <[email protected]> Date: Mon May 20 14:20:25 2013 -0700 Merge pull request tastejs#565 from stephenplusplus/gh-pages Updated the cujoJS readme. commit 05b1ce1 Author: Stephen Sawchuk <[email protected]> Date: Mon May 20 16:59:34 2013 -0400 cujo readme updated. commit b78a80a Author: Pascal Hartig <[email protected]> Date: Mon May 20 21:21:54 2013 +0200 Added know cujoJS to learn.json commit af7fafc Author: Pascal Hartig <[email protected]> Date: Mon May 20 21:19:27 2013 +0200 cujo css: consistent css indention commit 349aa2c Author: Pascal Hartig <[email protected]> Date: Mon May 20 21:18:12 2013 +0200 Updated changelog commit 4f633c5 Author: Pascal Hartig <[email protected]> Date: Mon May 20 21:16:25 2013 +0200 Removed es5 option from jshintrc It's a default as of jshint 2.0 commit 8152c9f Merge: 9972d21 b8d9ae5 Author: Pascal Hartig <[email protected]> Date: Mon May 20 12:15:09 2013 -0700 Merge pull request tastejs#556 from cujojs/cujo-lib-update Update to latest cujo releases commit b8d9ae5 Author: Brian Cavalier <[email protected]> Date: Fri May 10 14:53:00 2013 -0400 Update to latest cujo releases via bower. Handle enter key when editing todo but not changing it. Remove Template by. Remove unnecessary files. commit 9972d21 Author: Pascal Hartig <[email protected]> Date: Sat May 18 14:53:53 2013 +0200 Unbreak todomvc.com hosting commit c5ffea4 Merge: 868271f 3e6e853 Author: Addy Osmani <[email protected]> Date: Sat May 18 04:38:14 2013 -0700 Merge pull request tastejs#547 from stephenplusplus/readmes More helpful readmes for beginners - epic work by stephen. commit 3e6e853 Author: Stephen Sawchuk <[email protected]> Date: Thu May 16 11:52:56 2013 -0400 add more helpful readmes and learn.json. commit 868271f Merge: d3e1ac8 5f742d2 Author: Addy Osmani <[email protected]> Date: Fri May 17 10:52:37 2013 -0700 Merge pull request tastejs#558 from thebakeryio/refactoring/update-count Refactoring/update count commit 5f742d2 Author: callmephilip <[email protected]> Date: Mon May 13 09:27:09 2013 -0700 move logic from updateCount into the view rendering routine update footer template to support declarative task stats rendering adjust if block formatting remove unnecessary escaping from the footer template adjust variable declaration statements adjust indentation in the footer template commit d3e1ac8 Merge: 7a337a5 57d0c3e Author: Pascal Hartig <[email protected]> Date: Fri May 17 01:37:00 2013 -0700 Merge pull request tastejs#563 from txmikester/angular-test-fix Fixed broken AngularJS test runner commit 57d0c3e Author: Mike Haney <[email protected]> Date: Fri May 17 01:42:23 2013 -0500 Fixed broken AngularJS test runner Incorrect paths in the testacular.conf.js file prevented the tests from running. Also, updated package.json to use karma instead of testacular (project was renamed) commit 7a337a5 Merge: b6d929c f434c38 Author: Pascal Hartig <[email protected]> Date: Thu May 16 01:19:20 2013 -0700 Merge pull request tastejs#562 from rahulcs/ember-revision Update ember data revision from 11 to 12 commit f434c38 Author: Rahul Chanila <[email protected]> Date: Thu May 16 13:33:26 2013 +0530 Update ember data revision from 11 to 12 commit b6d929c Author: Addy Osmani <[email protected]> Date: Sat May 11 19:18:36 2013 +0100 For tastejs#453 - adds initial angular-perf readme. commit e3674e7 Author: Addy Osmani <[email protected]> Date: Sat May 11 18:58:57 2013 +0100 Several minor updates: - Add avatar and description for Gianni - Add Pascal to the copyright list - Fleshing out RequireJS apps in readme commit 4ad2192 Author: Sindre Sorhus <[email protected]> Date: Sat May 11 18:47:11 2013 +0200 Update paths to tastejs/todomvc repo commit e38f482 Merge: ba32f91 50c49f7 Author: Sindre Sorhus <[email protected]> Date: Thu May 9 11:26:42 2013 -0700 Merge pull request tastejs#555 from stephenplusplus/template-bower template/ updated with bower.json/bower_components. commit 50c49f7 Author: Stephen Sawchuk <[email protected]> Date: Thu May 9 13:28:54 2013 -0400 template/ updated with bower.json/bower_components. commit ba32f91 Merge: c08c83b c9d80c1 Author: Sindre Sorhus <[email protected]> Date: Thu May 9 06:39:47 2013 -0700 Merge pull request tastejs#552 from stephenplusplus/cujo_bower cujo updated to use bower. commit c9d80c1 Author: Stephen Sawchuk <[email protected]> Date: Thu May 9 04:56:20 2013 -0400 cujo updated to use bower. commit c08c83b Merge: ac970f5 a59d566 Author: Pascal Hartig <[email protected]> Date: Sun May 5 17:44:22 2013 -0700 Merge pull request tastejs#551 from stephenplusplus/ember_sample add source and demo link to ember+rjs readme commit a59d566 Author: Stephen Sawchuk <[email protected]> Date: Sun May 5 20:41:36 2013 -0400 add source and demo link to ember+rjs readme commit ac970f5 Author: Pascal Hartig <[email protected]> Date: Mon May 6 01:23:05 2013 +0200 emberjs_require: Fix redirect case sensitivity commit cde6f81 Author: Pascal Hartig <[email protected]> Date: Mon May 6 01:17:17 2013 +0200 Updated changelog, homepage, readme to reflect ember+rjs removal commit e8cfeae Author: Pascal Hartig <[email protected]> Date: Mon May 6 01:14:38 2013 +0200 Remove emberjs-require example, redirect to README Close tastejs#528 commit 41ef0d4 Merge: 37174a6 dccfdac Author: Sindre Sorhus <[email protected]> Date: Sun May 5 07:26:19 2013 -0700 Merge pull request tastejs#545 from thebakeryio/feature/backbone-marionette-model-shortcuts use Marionette's event hashes for Model and Collection events commit 37174a6 Merge: 29a5abc 629c07e Author: Addy Osmani <[email protected]> Date: Sat May 4 04:02:14 2013 -0700 Merge pull request tastejs#550 from OscarGodson/patch-1 Updated README to reflect new Vanilla JS project commit 629c07e Author: Oscar Godson <[email protected]> Date: Fri May 3 15:02:33 2013 -0700 Updated README to reflect new Vanilla JS project commit 29a5abc Merge: b8365f4 3e59664 Author: Addy Osmani <[email protected]> Date: Fri May 3 14:16:46 2013 -0700 Merge pull request tastejs#510 from OscarGodson/gh-pages VanillaJS app rewrite - landed! commit b8365f4 Merge: 8ea9aef 537d6e1 Author: Pascal Hartig <[email protected]> Date: Thu May 2 12:13:03 2013 -0700 Merge pull request tastejs#548 from stephenplusplus/serenadejs-bug serenade.js typo. commit 537d6e1 Author: Stephen Sawchuk <[email protected]> Date: Thu May 2 15:11:15 2013 -0400 serenade.js typo. commit dccfdac Author: callmephilip <[email protected]> Date: Wed May 1 10:44:08 2013 -0700 use Marionette's event hashes for Model and Collection events refer to Marionette's documentation for more details https://github.com/marionettejs/backbone.marionette/blob/master/docs/marionette.view.md#viewmodelevents-and-viewcollectionevents commit 3e59664 Author: Stephen Sawchuk <[email protected]> Date: Wed May 1 13:17:31 2013 -0400 component.json/components -> bower.json/bower_components commit 6de9e4b Author: Oscar Godson <[email protected]> Date: Wed May 1 08:41:38 2013 -0700 Ticket tastejs#510 - Put all the codez in a global namespace commit f7e1b55 Author: Stephen Sawchuk <[email protected]> Date: Wed May 1 11:08:06 2013 -0400 Array.filter && !empty todos && `addItem` simplification. commit e6f1497 Author: Oscar Godson <[email protected]> Date: Sat Nov 24 22:04:54 2012 -0800 TodoMVC app in vanilla JS. No, that's not a framework.
|
i'll try to take a look and fix the bb+requirejs anything else than lack of trimming the input value? |
|
ok, boss :D |
This was referenced Oct 30, 2013
gustaff-weldon
pushed a commit
to gustaff-weldon/todomvc
that referenced
this issue
Dec 23, 2013
gustaff-weldon
pushed a commit
to gustaff-weldon/todomvc
that referenced
this issue
Dec 23, 2013
|
there's still unchecked items if anyone is interested ;) |
|
I edited the above list to match reality a little more. Mainly ticking the ones that are done :) |
|
Can the title here be changed to be more specific and tagged to reflect the remaining tasks? Is there a unit test that could be made to find this? Sounds like the bug is that the text is initially selected when editing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi. I'm modeling after the existing todos for my work, and here are some small quirks I've noticed in the existing stable ones:
The text was updated successfully, but these errors were encountered: