Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Aurelia out of Labs #1963

Open
EisenbergEffect opened this issue Feb 16, 2019 · 4 comments
Open

Move Aurelia out of Labs #1963

EisenbergEffect opened this issue Feb 16, 2019 · 4 comments

Comments

@EisenbergEffect
Copy link

EisenbergEffect commented Feb 16, 2019

Is there some reason why this project has insisted on keeping Aurelia in "labs" for three years? We have tens of thousands of customers in production with Aurelia. Is there some problem with what has been submitted? We would have been happy to fix any issues a long time ago. Can we please move this along? This is really frustrating.

@FadySamirSadek
Copy link
Collaborator

@EisenbergEffect Thank you so much for contributing to TodoMVC. I am very sorry you feel that way but it has been hard maintaining all the examples in TodoMVC and following up with framework changes. But TodoMVC is an open source project and it wouldn't have been possible without the awesome community and contributions. The Aurelia example has not been updated since 2016 and this is the first time anyone from the Aurelia community requested that we move the Aurelia example out of labs. That being said I think Aurelia is now mature enough and is complying with our example guidelines so once anyone from the Aurelia community opens a PR to update the example and move it out of labs. I'll review it and if everything is fine it'll be merged.

@EisenbergEffect
Copy link
Author

Thank you @FadySamirSadek 😄 We can certainly get someone to work on this. Do you have some instructions on what needs to be done to move it out of labs? Is it just a matter of moving a folder from one place to another?

@sindresorhus
Copy link
Member

Also ensure the example app is following the latest Aurelia best practices.

@EisenbergEffect
Copy link
Author

@FadySamirSadek We have submitted a PR to update Aurelia. It's available here: #1969 It would be great to get this updated on that site. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants