-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The README in each example's folder should have the version number of the MVC framework used #1476
Comments
I like this idea, seems like something we could add to learn.json in the sidebar @tastejs/todomvc thoughts? |
👍 |
👍 for having it in the learn bar |
Support for this idea for the learn bar too. |
Agreeeed. On Fri, 16 Oct 2015 at 09:26 Addy Osmani [email protected] wrote:
|
@samccone i can do a PR for this but need some guidance. how about storing version like this in
|
I like this idea @beatfreaker however, I wonder what we should do for composite examples... like react + backbone... any thoughts? |
maybe this ☝️ ? |
👍 yeah we can go with array so this |
yep :) you got it |
okay and so we have to navigate to every example folder manually to get the version of framework used and then populate it in learn.json right? |
unfortunately yes 😬 |
haha okay will try to make a PR this weekend and what about displaying it in side bar? any thought where to display it any specific place or else? |
woot! cool. We can tackle the display part after we get the initial data in :) |
+1! This may help to draw attention to examples based on outdated libs and prevent issues like #1748. |
I would be very supportive of this. I think the sidebar would be a pretty fair place to visualize version info. |
If I'm looking at the source code of one of the examples, there's no way for me to know what version of the MVC framework they are made with. The code could be very outdated and I would have no idea - for example, as of the time of this post, the emberjs example is very out of date. Sure, sometimes you can get the version number from the project's
package.json
, but many of the projects don't have one. This just seems like a critical piece of information that would be the first thing any developer would want to know.The text was updated successfully, but these errors were encountered: