Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus on load #1029

Open
5 of 7 tasks
sindresorhus opened this issue Oct 16, 2014 · 12 comments
Open
5 of 7 tasks

Focus on load #1029

sindresorhus opened this issue Oct 16, 2014 · 12 comments

Comments

@sindresorhus
Copy link
Member

sindresorhus commented Oct 16, 2014

Some apps are not focusing the new todo input on load:

  • enyo_backbone
  • extjs_deftjs
  • olives
  • gwt
  • batman
  • agilityjs
  • componentjs

@ColinEberhardt Do we test for this in the testsuite?

Also, would you be interested in fixing the GWT app?

@ColinEberhardt
Copy link
Member

No, we don't test for this, because it's not in the spec ;-)

I'll see if I can add it in and do a full test run.

@ColinEberhardt
Copy link
Member

Regarding GWT, I'm afraid I'll have to decline on that one. I haven't used GWT for a couple of years now (and don't miss it much!)

@sindresorhus
Copy link
Member Author

No, we don't test for this, because it's not in the spec ;-)

It is now: cc97e9c

I'll see if I can add it in and do a full test run.

Awesome!

Regarding GWT, I'm afraid I'll have to decline on that one. I haven't used GWT for a couple of years now (and don't miss it much!)

No worries. Do you know anyone/anywhere we can reach out to?

@ColinEberhardt
Copy link
Member

I've updated the test, and the failures I see are for

  • agilityjs
  • batman
  • componentjs
  • enyo_backbone
  • olives

@sindresorhus that differs from your list slightly. I have manually verified extjs_deftjs and it works for me.

@sindresorhus
Copy link
Member Author

I have manually verified extjs_deftjs and it works for me

Which browser? Focuses on load in Safari, but not in latest Chrome.

@ColinEberhardt
Copy link
Member

Which browser? Focuses on load in Safari, but not in latest Chrome.

Just tried on 38.0.2125.104 (on a Mac), and it works fine.

@sindresorhus
Copy link
Member Author

I'm on OS X 10.9 and can reproduce in Chrome Canary too (without any extensions enabled).

ColinEberhardt referenced this issue Oct 17, 2014
This adds an additional test case that ensures the todo input field is focussed when the app initially loads.

Thia relates to the test failures in issue #1034
@ColinEberhardt
Copy link
Member

I must be going mad, extjs_deftjs does repeatedly fail now:

$ mocha allTests.js --no-timeouts --reporter spec --grep initially --framework extjs_deftjs --no-colors 
  TodoMVC - extjs_deftjs
    When page is initially opened
      1) should focus on the todo input field


  0 passing (6s)

@arthurvr
Copy link
Member

//cc @podefr @rse @corroded

@podefr
Copy link
Contributor

podefr commented Mar 28, 2015

Thanks again for the ping, will add this to Olives asap.

@corroded
Copy link

thanks for the ping. i haven't touched batman for a couple of years now (have been more focused in backbone tbh). Also, batman is not actively developed/maintained now :(

https://github.com/batmanjs/batman

@podefr
Copy link
Contributor

podefr commented Mar 31, 2015

Hey, I created #1242 which fixes the autofocus bug. Thanks!

arthurvr pushed a commit that referenced this issue Apr 27, 2015
* Update to the latest version of the Olives framework.
* Update to the latest version of Emily
* Remove requirejs in favor of browserify
   - also implemented npm scripts and updated the readme

As a result of updating dependencies, this fixes the issue in #1029.

Ref #1029
Close #1242
@arthurvr arthurvr removed the olives label Apr 27, 2015
mhoyer pushed a commit to mhoyer/todomvc that referenced this issue Dec 5, 2015
mhoyer pushed a commit to mhoyer/todomvc that referenced this issue Dec 5, 2015
* Update to the latest version of the Olives framework.
* Update to the latest version of Emily
* Remove requirejs in favor of browserify
   - also implemented npm scripts and updated the readme

As a result of updating dependencies, this fixes the issue in tastejs#1029.

Ref tastejs#1029
Close tastejs#1242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants