bug: Jira Branch Names Not Being Picked Up

[therynamo]

There is an issue where, even if you use the correct branch name, CL does not pick up the changes for the changelog.

Notes: It is probably the regex that is the issue.

[benzvan]

I'll take a quick look. I think this is the regex you're referring to:

captains-log/src/utils/ticketFinder/finders/jira/index.js

Line 8 in 68e1fca

const branchRegex = /([[A-Z][A-Z0-9]*-[1-9][0-9]*)\]?/;

[therynamo]

That would be the one!

[benzvan]

\]? is definitely unnecessary but shouldn't harm anything. The regex should match correctly at least for all our example.

[therynamo]

Bummer. Well, that isn't what I wanted to hear 😄. If that is the case then we'll have to dive a little deeper. I can debug it some time later today to verify what is going on here. I'll connect with you for some test data, offline.

Thanks for verifying that @benzvan!

[benzvan]

Here's a really small PR to add tests #51

[benzvan]

I think jiraFinder just isn't being called anywhere.

[benzvan]

I see where it's used now, I think. I don't understand this code well enough to figure out the problem.

[therynamo]

It can get a bit convoluted at times, that is for sure. I'm sure a refactor is on our roadmap some time in the future 😄.

I have a feeling it has to do with the commits being exposed to the ticket finders. I recently changed how the commit searches work because we were hitting rate limits. If you don't squash and merge it may be incorrectly grabbing the commits associated with your release. It is a weird scenario, and I'm hoping that is not the issue, but that is my theory right now.

Edit code that changed: https://github.com/target/captains-log/pull/45/files#diff-bb4627ea32ef9426b04989a45066c1b8R85-R93

[benzvan]

It worked once!

[therynamo]

Awesome! Glad to hear it! Can you check and see what the branch name was?

[benzvan]

prod-loglevel/RP-2636

[benzvan]

Taking another look at this because I had time. I notice the regex in the code is also looking for square bracket characters in an odd way. Maybe /([A-Z][A-Z0-9]*-[1-9][0-9]*)/ would be better?

[therynamo]

You're right! I think that may be a typo!