Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taoensso.tempura.impl/vargs should be customizable #13

Open
ai212983 opened this issue May 17, 2017 · 0 comments
Open

taoensso.tempura.impl/vargs should be customizable #13

ai212983 opened this issue May 17, 2017 · 0 comments

Comments

@ai212983
Copy link

First for all, thanks for awesome library! It's damn quick and very flexible.

I have a suggestion though. I think taoensso.tempura.impl/vargs should be customizable via params, like resource-compiler.

Reason is custom resource compiler params are passed through vargs, which strips everything to vector. So supporting something like MessageFormat is not easy, because it works with map.

Of course, it's possible to workaround this by wrapping map into vector, like

(tr :message-format [{:fruit "Apple" :amount 2}])

and making a check inside of custom resource compiler, but that's a bit hack-ish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants