fixup! Use instanceOfNodeError

eslint.config.mjs

@@ -3,7 +3,6 @@ import tseslint from 'typescript-eslint';
 
 const commonRules = {
     "@typescript-eslint/no-explicit-any": "off",
-    "@typescript-eslint/no-empty-function": "off",
     "@typescript-eslint/consistent-type-assertions": ["error", {
         assertionStyle: "as",
         objectLiteralTypeAssertions: "never",

src/components/snippetview.ts

@@ -114,7 +114,7 @@ class SnippetViewProvider implements vscode.WebviewViewProvider {
             const editor = this.lastActiveTextEditor
             if (editor) {
                 editor.insertSnippet(new vscode.SnippetString(message.snippet.replace(/\\\n/g, '\\n'))).then(
-                    () => {},
+                    () => undefined,
                     err => {
                         void vscode.window.showWarningMessage(`Unable to insert symbol, ${err}`)
                     }

src/components/viewerlib/pdfviewerhook.ts

@@ -13,7 +13,7 @@ export class PdfViewerHookProvider implements vscode.CustomReadonlyEditorProvide
     openCustomDocument(uri: vscode.Uri) {
         return {
             uri,
-            dispose: () => {}
+            dispose: () => undefined
         }
     }
 

src/utils/externalpromise.ts

@@ -1,6 +1,6 @@
 function promiseTriplet<T>() {
-    let resolve: ((value: T | PromiseLike<T>) => void) = () => {}
-    let reject: ((reason?: any) => void) = () => {}
+    let resolve: ((value: T | PromiseLike<T>) => void) = () => undefined
+    let reject: ((reason?: any) => void) = () => undefined
     const promise = new Promise<T>((r, rej) => {
         resolve = r
         reject = rej

test/unittests/components/locatorlib/synctex.test.ts

@@ -8,8 +8,7 @@ import { inspect } from 'node:util'
 
 suite('unit test suite', () => {
 
-    suiteSetup(() => {
-    })
+    suiteSetup(() => undefined)
 
     runUnitTestWithFixture('fixture001', 'test synctex', () => {
         const fixtureDir = getFixtureDir()

test/utils/fakecomponents.ts

@@ -1,10 +1,10 @@
 import { ILogger } from '../../src/interfaces.js'
 
 export class FakeLogger implements ILogger {
-    info() {}
-    logCommand() {}
-    debug(){}
-    error(){}
-    logError() {}
-    showLog() {}
+    info() { return }
+    logCommand() { return }
+    debug() { return }
+    error() { return }
+    logError() { return }
+    showLog() { return }
 }