Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM version outdated #82

Open
furliq opened this issue Sep 9, 2020 · 4 comments
Open

NPM version outdated #82

furliq opened this issue Sep 9, 2020 · 4 comments

Comments

@furliq
Copy link

furliq commented Sep 9, 2020

Is there a reason this package hasn't been published to npm? I'd like to use this package but I have to clone it because I need the latest version.

Thanks.

@a-sync
Copy link
Collaborator

a-sync commented Sep 10, 2020

There are no tests or active maintainers to make sure features work as intended. (i don't want to break anyone's code by publishing an untested version)

You can add the github repo directly as a dependency in npm.
eg.: npm i tamkeen-tms/electron-window-manager#master

@furliq
Copy link
Author

furliq commented Sep 10, 2020

@a-sync Ok thanks for the info. See this mentioned in PR #81 too.

Is there any preferred approach to writing tests?

@a-sync
Copy link
Collaborator

a-sync commented Sep 10, 2020

Nothing established here. Spectron could be a good approach perhaps. https://www.electronjs.org/docs/tutorial/automated-testing-with-a-custom-driver

But more then anything this repo would benefit from a rewrite in typescript, and an update to the core functions using electron APIs to support the latest version and features/options.

@furliq
Copy link
Author

furliq commented Sep 10, 2020

Agreed. Definitely more of a long term goal but at least you've laid out some of the first steps. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants