Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash: division by 0 #43

Open
supermerill opened this issue Dec 15, 2021 · 0 comments
Open

crash: division by 0 #43

supermerill opened this issue Dec 15, 2021 · 0 comments

Comments

@supermerill
Copy link

supermerill commented Dec 15, 2021

Hello
I had a division by 0 in the geometry_traits_nfp:l285
the reason is that lsq1 is equal to 0 because e1.second() == e1.first()
I don't know if it's the intended behaviour or not.
I fixed it by replacing

            auto pcos1 = Ratio(lcos[0]) / lsq1 * sign * lcos[0];
            auto pcos2 = Ratio(lcos[1]) / lsq2 * sign * lcos[1];

by

            auto pcos1 = lsq1 != 0 ? Ratio(lcos[0]) / lsq1 * sign * lcos[0] : 1 * sign * lcos[0];
            auto pcos2 = lsq2 != 0 ? Ratio(lcos[1]) / lsq2 * sign * lcos[1] : 1 * sign * lcos[1];

Or maybe add an assert to test the input if it's the intended behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant