Sky rendering is incorrect on mobile

[gkjohnson]

On my Samsung Galaxy S20 device - looks like the adjusted depth comparison from #3 (comment) is not so fool-proof 😬 Maybe there's a better way to handle this? Is there a reason DepthTextures aren't used here which might make this easier? Maybe that's an EffectComposer limitation? I'll have to think through a solution more.

[shotamatsuda]

Although I'm not familiar with DepthTexture (after seeing the example), isn’t it overwritten during post-processing renders? It seems postprocessing is working around this in the pipeline redesign, which might address it.

As for the epsilon, is 1e-7 too small? Will something closer to 1e-6 (matching what common.glsl defines) resolve the issue?

[gkjohnson]

As for the epsilon, is 1e-7 too small?

It must be - I'll try different values on my phone when I get a chance to see if anything fixes it. Or maybe another solution will come to mind.

[shotamatsuda]

Just to add, I tried comparing the view Z instead of the depth value, but it didn’t work well for some reason I’m not sure. Maybe I need to revisit it.

[gkjohnson]

Turns out this isn't a depth issue at all 🤷 - see #26. Gotta love inconsistent behavior between platforms 😅