Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal break when node=document.body #211

Open
hepiyellow opened this issue May 29, 2018 · 0 comments
Open

Portal break when node=document.body #211

hepiyellow opened this issue May 29, 2018 · 0 comments

Comments

@hepiyellow
Copy link

Naively I set <Portal node={document.body} >... and it breaks with react 15 (works with 16).
When I say break, I mean that the portal content is replacing the body instead of appending to it.

Until I figured out that I can simply omit the node prop, and use react-portal's default behaviour.

I just thought this is something that might either require special code handling,
or at least a stronger mention in the documentation.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant