New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vite HMR config does not override Ladle default config #557
Labels
needs triage
needs to be reviewed
Comments
This PR is not ready to be merged, I don't have time to get the project set up locally right now to test things fully, but this should be a good example of a fix for the problem: #558 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When trying to use
vite.config.mjs
to override the default HMR settings (server.hmr
) the settings invite.config.mjs
are never applied.Reproduction
I'm trying to run
ladle
within adocker
container. The problem I am having is that the WS connection to my docker container fails and to fix this I need to override the HMR host. Essentially:nodejs
favours IPV6.localhost
as the HMR host (forced by ladle) starts server on IPV6.docker
setup.To reproduce this issue simply attempt to change
server.hmr.host
orserver.hmr.port
in your.ladle/vite.config.mjs
and it will not be applied.I think I have found the issue within the codebase:
Potential Fix
I'm not 100% certain, but from a quick glance I think a fix would be adding HMR settings to the
ladle
config, and then merging them in here as we do with the other settings in theladle
config.The text was updated successfully, but these errors were encountered: