-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: don't refresh the pacman repository on Arch #12194
base: main
Are you sure you want to change the base?
Conversation
scripts/installer.sh
Outdated
# https://github.com/tailscale/tailscale/issues/12186 | ||
if [ "$OS" != "arch" ]; then | ||
$SUDO pacman -Sy | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like the issue is not specific to Arch, but any distro using pacman.
We should probably never run pacman -Sy
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it need to use pacman -Sy
anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's similar to all other repos - refresh the index to fetch the latest version. Arch is the only one that actually discourages this practice.
It matters more on rpm and deb-based distros, where we own the repo and add it in this same installer script. Without a refresh, apt/dnf/yum wouldn't know about the tailscale package.
I agree that it is probably not necessary on pacman-based distros, unless you have a fresh install where pacman -Sy
has never ran before (e.g. when you run a fresh archlinux
docker container`).
The Arch CI is broken because it does not already have the package database downloaded like a regular system would. |
@noncombatant we need to update the CI config to special-case tailscale/.github/workflows/installer.yml Lines 70 to 77 in 0614988
|
I've just checked, and the installer script will fail on a fresh
If it's not always safe to run that command, I think we have two options:
|
We could do |
0614988
to
b0c423f
Compare
On Arch and other rolling release |
Fixes #12186 Signed-off-by: Chris Palmer <[email protected]>
b0c423f
to
d13f01e
Compare
Fixes #12186